fix: validator check for integers was broken.

[cmeesters]

Summary by CodeRabbit

• Bug Fixes
  • Validation updated for the initialization delay before status checks: integer values of 1 and above are now accepted, whereas previously only zero or negative values were allowed. Type checking remains enforced so only integers are permitted.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Validation for init_seconds_before_status_checks was changed: the invalid condition moved from values greater than 0 to values less than 1, so integer values >= 1 are now accepted while values < 1 are rejected; type-checking (integers only) remains unchanged.

Changes

Cohort / File(s)	Change Summary
Validation update snakemake_executor_plugin_slurm/validation.py	Adjusted validation for init_seconds_before_status_checks: invalid condition changed from > 0 to < 1, shifting allowed integers to >= 1 and rejecting values < 1. No signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single-file logical change with low complexity
• Review should confirm integer-only type check and boundary behavior (0 vs 1)
• Verify unit tests or add tests for values: -1, 0, 1, 2

Poem

🐰 Once a rule barred all the bright sun,
Now it hops open for numbers >= one,
Zero's tucked out, negatives flee,
The validator nods, content as can be—
A little fix, a carrot for me. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing a broken validator check for integers in the init_seconds_before_status_checks validation condition.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/validator

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2273aa and 47a5d7c.

📒 Files selected for processing (1)

• snakemake_executor_plugin_slurm/validation.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• snakemake_executor_plugin_slurm/validation.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: testing

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

snakemake_executor_plugin_slurm/validation.py (1)

132-139: Clarify error message to match new non-negative validation

The updated condition now correctly rejects negative values and allows 0 and positive integers. The error text still says “must be a positive integer”, which usually implies > 0, so it no longer precisely reflects the behavior.

Consider updating the message to “non-negative integer” (or adjusting the condition to <= 0 if you truly want strictly positive values):

-                "init-seconds-before-status-checks must be a positive integer."
+                "init-seconds-before-status-checks must be a non-negative integer."

This keeps the user-facing message aligned with the fixed validation logic.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4458d23 and a2273aa.

📒 Files selected for processing (1)

• snakemake_executor_plugin_slurm/validation.py (1 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 0
File: :0-0
Timestamp: 2025-01-13T09:54:22.950Z
Learning: PR #173 (adding gres resource specification) depends on PR #28 in snakemake-executor-plugin-slurm-jobstep repository, as changes were required in the cpu-settings function of the jobstep-Executor module.

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 193
File: .github/workflows/post_to_mastodon.yml:26-26
Timestamp: 2025-01-20T09:13:26.443Z
Learning: In the snakemake-executor-plugin-slurm repository, release PRs follow the naming pattern "chore(main): release X.Y.Z" where X.Y.Z is the version number.

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 249
File: snakemake_executor_plugin_slurm/submit_string.py:21-29
Timestamp: 2025-03-31T11:52:05.373Z
Learning: In the snakemake-executor-plugin-slurm project, account and partition parameters are validated in the submit function before reaching the get_submit_command function. By design, these parameters are either empty strings or already properly formatted with SLURM parameter tags, making additional validation in get_submit_command unnecessary.

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 355
File: snakemake_executor_plugin_slurm/submit_string.py:23-30
Timestamp: 2025-09-15T12:00:31.977Z
Learning: In the snakemake-executor-plugin-slurm project, the parameters params.run_uuid, params.slurm_logfile, and params.comment_str are always provided and never None, so validation for None values is not necessary for these specific parameters in the get_submit_command function.

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 221
File: snakemake_executor_plugin_slurm/efficiency_report.py:0-0
Timestamp: 2025-06-16T08:54:07.957Z
Learning: In the context of SLURM executor plugin development, user cmeesters (experienced with SLURM) noted they are not aware of SLURM typically reporting memory values with decimals (like 1.5G), but accepted defensive programming to handle such cases anyway.

📚 Learning: 2025-03-31T11:52:05.373Z

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 249
File: snakemake_executor_plugin_slurm/submit_string.py:21-29
Timestamp: 2025-03-31T11:52:05.373Z
Learning: In the snakemake-executor-plugin-slurm project, account and partition parameters are validated in the submit function before reaching the get_submit_command function. By design, these parameters are either empty strings or already properly formatted with SLURM parameter tags, making additional validation in get_submit_command unnecessary.

Applied to files:

• snakemake_executor_plugin_slurm/validation.py

📚 Learning: 2024-12-11T14:17:08.749Z

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 178
File: snakemake_executor_plugin_slurm/__init__.py:0-0
Timestamp: 2024-12-11T14:17:08.749Z
Learning: In the `snakemake-executor-plugin-slurm` project, when handling exceptions in `snakemake_executor_plugin_slurm/__init__.py`, prefer concise error messages and avoid unnecessary verbosity or exception chaining when it's not necessary.

Applied to files:

• snakemake_executor_plugin_slurm/validation.py

📚 Learning: 2025-09-15T12:00:31.977Z

Learnt from: cmeesters
Repo: snakemake/snakemake-executor-plugin-slurm PR: 355
File: snakemake_executor_plugin_slurm/submit_string.py:23-30
Timestamp: 2025-09-15T12:00:31.977Z
Learning: In the snakemake-executor-plugin-slurm project, the parameters params.run_uuid, params.slurm_logfile, and params.comment_str are always provided and never None, so validation for None values is not necessary for these specific parameters in the get_submit_command function.

Applied to files:

• snakemake_executor_plugin_slurm/validation.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: testing