Skip to content

Commit cf3c193

Browse files
committed
Polish "Associate MeterConventions for JVM and system metrics"
See spring-projectsgh-47935
1 parent 74fd35e commit cf3c193

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/jvm/JvmMetricsAutoConfigurationTests.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.junit.jupiter.api.Test;
3333
import org.junit.jupiter.api.condition.EnabledForJreRange;
3434
import org.junit.jupiter.api.condition.JRE;
35-
import org.mockito.Mockito;
3635

3736
import org.springframework.aot.hint.MemberCategory;
3837
import org.springframework.aot.hint.RuntimeHints;
@@ -48,6 +47,7 @@
4847
import org.springframework.util.ClassUtils;
4948

5049
import static org.assertj.core.api.Assertions.assertThat;
50+
import static org.mockito.Mockito.mock;
5151

5252
/**
5353
* Tests for {@link JvmMetricsAutoConfiguration}.
@@ -88,7 +88,7 @@ void allowsCustomJvmMemoryMetricsToBeUsed() {
8888

8989
@Test
9090
void allowCustomJvmMemoryMeterConventionsToBeUsed() {
91-
JvmMemoryMeterConventions jvmMemoryMeterConventions = Mockito.mock(JvmMemoryMeterConventions.class);
91+
JvmMemoryMeterConventions jvmMemoryMeterConventions = mock(JvmMemoryMeterConventions.class);
9292
this.contextRunner.withBean(JvmMemoryMeterConventions.class, () -> jvmMemoryMeterConventions)
9393
.run((context) -> assertThat(context).hasSingleBean(JvmMemoryMetrics.class)
9494
.getBean(JvmMemoryMetrics.class)
@@ -103,7 +103,7 @@ void allowsCustomJvmThreadMetricsToBeUsed() {
103103

104104
@Test
105105
void allowCustomJvmThreadMeterConventionsToBeUsed() {
106-
JvmThreadMeterConventions jvmThreadMeterConventions = Mockito.mock(JvmThreadMeterConventions.class);
106+
JvmThreadMeterConventions jvmThreadMeterConventions = mock(JvmThreadMeterConventions.class);
107107
this.contextRunner.withBean(JvmThreadMeterConventions.class, () -> jvmThreadMeterConventions)
108108
.run((context) -> assertThat(context).hasSingleBean(JvmThreadMetrics.class)
109109
.getBean(JvmThreadMetrics.class)
@@ -118,8 +118,7 @@ void allowsCustomClassLoaderMetricsToBeUsed() {
118118

119119
@Test
120120
void allowCustomJvmClassLoadingMeterConventionsToBeUsed() {
121-
JvmClassLoadingMeterConventions jvmClassLoadingMeterConventions = Mockito
122-
.mock(JvmClassLoadingMeterConventions.class);
121+
JvmClassLoadingMeterConventions jvmClassLoadingMeterConventions = mock(JvmClassLoadingMeterConventions.class);
123122
this.contextRunner.withBean(JvmClassLoadingMeterConventions.class, () -> jvmClassLoadingMeterConventions)
124123
.run((context) -> assertThat(context).hasSingleBean(ClassLoaderMetrics.class)
125124
.getBean(ClassLoaderMetrics.class)

module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/system/SystemMetricsAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import io.micrometer.core.instrument.binder.system.UptimeMetrics;
2828
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
2929
import org.junit.jupiter.api.Test;
30-
import org.mockito.Mockito;
3130

3231
import org.springframework.boot.autoconfigure.AutoConfigurations;
3332
import org.springframework.boot.micrometer.metrics.system.DiskSpaceMetricsBinder;
@@ -36,6 +35,7 @@
3635
import org.springframework.context.annotation.Configuration;
3736

3837
import static org.assertj.core.api.Assertions.assertThat;
38+
import static org.mockito.Mockito.mock;
3939

4040
/**
4141
* Tests for {@link SystemMetricsAutoConfiguration}.
@@ -75,7 +75,7 @@ void allowsCustomProcessorMetricsToBeUsed() {
7575

7676
@Test
7777
void allowsCustomJvmCpuMeterConventionsToBeUsed() {
78-
JvmCpuMeterConventions jvmCpuMeterConventions = Mockito.mock(JvmCpuMeterConventions.class);
78+
JvmCpuMeterConventions jvmCpuMeterConventions = mock(JvmCpuMeterConventions.class);
7979
this.contextRunner.withBean(JvmCpuMeterConventions.class, () -> jvmCpuMeterConventions)
8080
.run((context) -> assertThat(context).hasSingleBean(ProcessorMetrics.class)
8181
.getBean(ProcessorMetrics.class)

0 commit comments

Comments
 (0)