Skip to content

Commit ae012ae

Browse files
Ignore other providers for specific test for a provider
1 parent a8be169 commit ae012ae

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

Snowflake.Data.Tests/UnitTests/SFAzureClientTest.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ namespace Snowflake.Data.Tests.UnitTests
2222
using Azure.Storage.Blobs.Models;
2323

2424
[TestFixture]
25+
[IgnoreOnEnvIs("snowflake_cloud_env",
26+
new string[] { "GCP", "AWS" })]
2527
class SFAzureClientTest : SFBaseTest
2628
{
2729
// Mock data for file metadata
@@ -63,7 +65,7 @@ class SFAzureClientTest : SFBaseTest
6365
public void BeforeTest()
6466
{
6567
t_downloadFileName = TestNameWithWorker + "_mockFileName.txt";
66-
68+
6769
_fileMetadata = new SFFileMetadata()
6870
{
6971
stageInfo = new PutGetStageInfo()

Snowflake.Data.Tests/UnitTests/SFGCSClientTest.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ namespace Snowflake.Data.Tests.UnitTests
1919
using Moq;
2020

2121
[TestFixture]
22+
[IgnoreOnEnvIs("snowflake_cloud_env",
23+
new string[] { "AWS", "AZURE" })]
2224
class SFGCSClientTest : SFBaseTest
2325
{
2426
// Mock data for file metadata
@@ -56,7 +58,7 @@ class SFGCSClientTest : SFBaseTest
5658
public void BeforeTest()
5759
{
5860
t_downloadFileName = TestNameWithWorker + "_mockFileName.txt";
59-
61+
6062
_fileMetadata = new SFFileMetadata()
6163
{
6264
stageInfo = new PutGetStageInfo()

Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ public void BeforeTest()
115115
};
116116

117117
// Set the mock GCS client to use
118+
// TODO: ISSUE WITH SPLIT ALWAYS USING GCP SPECIFIC CLIENT IN TESTS
118119
_client = new SFGCSClient(_fileMetadata.stageInfo);
119120
_fileMetadata.client = _client;
120121

Snowflake.Data.Tests/UnitTests/SFS3ClientTest.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ namespace Snowflake.Data.Tests.UnitTests
2222
using Amazon.S3.Model;
2323

2424
[TestFixture]
25+
[IgnoreOnEnvIs("snowflake_cloud_env",
26+
new string[] { "GCP", "AZURE" })]
2527
class SFS3ClientTest : SFBaseTest
2628
{
2729
// Mock data for file metadata
@@ -81,7 +83,7 @@ class SFS3ClientTest : SFBaseTest
8183
public void BeforeTest()
8284
{
8385
t_downloadFileName = TestNameWithWorker + "_mockFileName.txt";
84-
86+
8587
_fileMetadata = new SFFileMetadata()
8688
{
8789
stageInfo = new PutGetStageInfo()
@@ -274,7 +276,7 @@ public async Task TestUploadFileAsync(string requestKey, ResultStatus expectedRe
274276
iv = MockS3Client.AmzIV,
275277
key = MockS3Client.AmzKey,
276278
matDesc = MockS3Client.AmzMatdesc
277-
},
279+
},
278280
_cancellationToken).ConfigureAwait(false);
279281

280282
// Assert
@@ -331,7 +333,7 @@ public async Task TestDownloadFileAsync(string requestKey, ResultStatus expected
331333
_client = new SFS3Client(_fileMetadata.stageInfo, MaxRetry, Parallel, _proxyCredentials, mockAmazonS3Client.Object);
332334
_fileMetadata.client = _client;
333335
_fileMetadata.stageInfo.location = requestKey;
334-
336+
335337
// Act
336338
await _client.DownloadFileAsync(_fileMetadata, t_downloadFileName, Parallel, _cancellationToken).ConfigureAwait(false);
337339

0 commit comments

Comments
 (0)