Skip to content

Commit 8ea9ab9

Browse files
authored
SNOW-1324105-dependency-pinning: move versions pinning from project env to metadata (#486)
* SNOW-1324105-dependency-pinning: move versions pinning from project env to metadata * SNOW-1324105-dependency-pinning: update version and description * SNOW-1324105-dependency-pinning: remove duplicated command in CI job
1 parent 4db4b95 commit 8ea9ab9

File tree

4 files changed

+34
-10
lines changed

4 files changed

+34
-10
lines changed

.github/workflows/build_test.yml

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,34 @@ jobs:
4545
- name: Run lint checks
4646
run: hatch run check
4747

48+
build-install:
49+
name: Test package build and installation
50+
runs-on: ubuntu-latest
51+
needs: lint
52+
steps:
53+
- uses: actions/checkout@v4
54+
with:
55+
persist-credentials: false
56+
- name: Setup up Python
57+
uses: actions/setup-python@v5
58+
with:
59+
python-version: '3.8'
60+
- name: Upgrade and install tools
61+
run: |
62+
python -m pip install -U pip
63+
python -m pip install -U hatch
64+
- name: Build package
65+
run: |
66+
python -m hatch clean
67+
python -m hatch build
68+
- name: Install and check import
69+
run: |
70+
python -m pip install dist/snowflake_sqlalchemy-*.whl
71+
python -c "import snowflake.sqlalchemy; print(snowflake.sqlalchemy.__version__)"
72+
4873
test-dialect:
4974
name: Test dialect ${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
50-
needs: lint
75+
needs: [ lint, build-install ]
5176
runs-on: ${{ matrix.os }}
5277
strategy:
5378
fail-fast: false
@@ -93,7 +118,7 @@ jobs:
93118
94119
test-dialect-compatibility:
95120
name: Test dialect compatibility ${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
96-
needs: lint
121+
needs: [ lint, build-install ]
97122
runs-on: ${{ matrix.os }}
98123
strategy:
99124
fail-fast: false
@@ -139,7 +164,7 @@ jobs:
139164
140165
test-dialect-run-v20:
141166
name: Test dialect run v20 ${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
142-
needs: lint
167+
needs: [ lint, build-install ]
143168
runs-on: ${{ matrix.os }}
144169
strategy:
145170
fail-fast: false

DESCRIPTION.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ Source code is also available at:
99

1010
# Release Notes
1111

12+
- v1.5.3(Unrelased)
13+
14+
- Limit SQLAlchemy to < 2.0.0 before releasing version compatible with 2.0
15+
1216
- v1.5.2(April 11, 2024)
1317

1418
- Bump min SQLAlchemy to 1.4.19 for outer lateral join

pyproject.toml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ classifiers = [
3838
"Topic :: Software Development :: Libraries :: Application Frameworks",
3939
"Topic :: Software Development :: Libraries :: Python Modules",
4040
]
41-
dependencies = ["snowflake-connector-python", "SQLAlchemy"]
41+
dependencies = ["snowflake-connector-python<4.0.0", "SQLAlchemy>=1.4.19,<2.0.0"]
4242

4343
[tool.hatch.version]
4444
path = "src/snowflake/sqlalchemy/version.py"
@@ -73,14 +73,9 @@ exclude = ["/.github"]
7373
packages = ["src/snowflake"]
7474

7575
[tool.hatch.envs.default]
76-
extra-dependencies = ["SQLAlchemy<2.0.0,>=1.4.19"]
7776
features = ["development", "pandas"]
7877
python = "3.8"
7978

80-
[tool.hatch.envs.sa20]
81-
extra-dependencies = ["SQLAlchemy>=2.0.0"]
82-
python = "3.8"
83-
8479
[tool.hatch.envs.default.env-vars]
8580
COVERAGE_FILE = "coverage.xml"
8681
SQLACHEMY_WARN_20 = "1"

src/snowflake/sqlalchemy/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
#
44
# Update this for the versions
55
# Don't change the forth version number from None
6-
VERSION = "1.5.2"
6+
VERSION = "1.5.3"

0 commit comments

Comments
 (0)