Fix ripple effect staying after cancellation (#2586)

m-bert · web-flow · commit 703fd3a96cf8 · 2023-09-18T11:27:05.000+02:00
## Description Sometimes when our `Button` (like `BaseButton`) is cancelled, it gets stuck at ripple animation. This may also prevent other components form receiving events, until the button will be pressed again (which will release it). This PR changes behavior after receiving `ACTION_CANCEL`, so that buttons don't get stuck anymore. Fixes #2585 ## Test plan Tested on example from [issue](#2585) and `NestedButtons` example from our example app.
diff --git a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt
@@ -174,6 +174,7 @@ class RNGestureHandlerButtonViewManager : ViewGroupManager<ButtonViewGroup>(), R
     override fun onTouchEvent(event: MotionEvent): Boolean {
       if (event.action == MotionEvent.ACTION_CANCEL) {
         tryFreeingResponder()
+        return super.onTouchEvent(event)
       }
 
       val eventTime = event.eventTime

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,7 @@ class RNGestureHandlerButtonViewManager : ViewGroupManager<ButtonViewGroup>(), R`
`174`	`174`	`override fun onTouchEvent(event: MotionEvent): Boolean {`
`175`	`175`	`if (event.action == MotionEvent.ACTION_CANCEL) {`
`176`	`176`	`tryFreeingResponder()`
	`177`	`+ return super.onTouchEvent(event)`
`177`	`178`	`}`
`178`	`179`
`179`	`180`	`val eventTime = event.eventTime`