ClangTidy warnings for `cppcoreguidelines-avoid-goto`

[jviotti]

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:35:9: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   35 |         goto parse_start;
      |         ^~~~~~~~~~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:39:1: note: label defined here
   39 | parse_start:
      | ^

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:58:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   58 |       goto element;
      |       ^~~~~~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:74:1: note: label defined here
   74 | element:
      | ^

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:65:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   65 |       goto start;
      |       ^~~~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:52:1: note: label defined here
   52 | start:
      | ^

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:68:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   68 |       goto end;
      |       ^~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:94:1: note: label defined here
   94 | end:
      | ^

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:82:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   82 |       goto element;
      |       ^~~~~~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:74:1: note: label defined here
   74 | element:
      | ^

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:85:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   85 |       goto end;
      |       ^~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:94:1: note: label defined here
   94 | end:
      | ^

/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:87:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
   87 |       goto next;
      |       ^~~~~~~~~
/Users/jviotti/Projects/core/src/core/jsonl/iterator.cc:90:1: note: label defined here
   90 | next:
      | ^

[jviotti]

We intentionally use goto in the parsers. It proved to have some performance benefits, at least back then when I was working on this and benchmarking it. Maybe we just need comment directives to shut this rule off in these specific cases