Merge pull request #62 from skollro/use-inserts

Use --inserts option for pgsql connections by default

Author: freekmurze

src/DbDumperFactory.php

@@ -46,7 +46,7 @@ protected static function forDriver($dbDriver): DbDumper
         }
 
         if ($driver === 'pgsql') {
-            return new PostgreSql();
+            return (new PostgreSql())->useInserts();
         }
 
         if ($driver === 'sqlite') {

tests/DbDumperFactoryTest.php

@@ -86,7 +86,7 @@ public function it_can_add_named_options_to_the_dump_command()
 
         $this->app['config']->set('database.connections.mysql.dump', $dumpConfig);
 
-        $this->assertContains('--single-transaction', $this->getDumpCommand());
+        $this->assertContains('--single-transaction', $this->getDumpCommand('mysql'));
     }
 
     /** @test */
@@ -96,7 +96,7 @@ public function it_can_add_named_options_with_an_array_value_to_the_dump_command
 
         $this->app['config']->set('database.connections.mysql.dump', $dumpConfig);
 
-        $this->assertContains(implode(' ', $dumpConfig['include_tables']), $this->getDumpCommand());
+        $this->assertContains(implode(' ', $dumpConfig['include_tables']), $this->getDumpCommand('mysql'));
     }
 
     /** @test */
@@ -106,14 +106,20 @@ public function it_can_add_arbritrary_options_to_the_dump_command()
 
         $this->app['config']->set('database.connections.mysql.dump', $dumpConfig);
 
-        $this->assertContains($dumpConfig['add_extra_option'], $this->getDumpCommand());
+        $this->assertContains($dumpConfig['add_extra_option'], $this->getDumpCommand('mysql'));
     }
 
-    protected function getDumpCommand(): string
+    /** @test */
+    public function it_adds_the_inserts_option_to_the_pgsql_dump_command()
+    {
+        $this->assertContains('--inserts', $this->getDumpCommand('pgsql'));
+    }
+
+    protected function getDumpCommand(string $connectionName): string
     {
         $dumpFile = '';
         $credentialsFile = '';
 
-        return DbDumperFactory::createForConnection('mysql')->getDumpCommand($dumpFile, $credentialsFile);
+        return DbDumperFactory::createForConnection($connectionName)->getDumpCommand($dumpFile, $credentialsFile);
     }
 }