Merge pull request #67 from Vusys/compress

Fix compression option from config not being respected

Author: freekmurze

src/Commands/Create.php

@@ -23,13 +23,13 @@ public function handle()
 
         $snapshotName = $this->argument('name') ?: Carbon::now()->format('Y-m-d_H-i-s');
 
-        $compress = $this->option('compress', null);
+        $compress = $this->option('compress') || config('db-snapshots.compress', false);
 
         $snapshot = app(SnapshotFactory::class)->create(
             $snapshotName,
             config('db-snapshots.disk'),
             $connectionName,
-            ($compress !== null) ? $compress : (bool) config('db-snapshots.compress', false)
+            $compress
         );
 
         $size = Format::humanReadableSize($snapshot->size());

tests/Commands/CreateTest.php

@@ -27,7 +27,7 @@ public function it_can_create_a_snapshot_with_specific_name()
     }
 
     /** @test */
-    public function it_can_create_a_compressed_snapshot()
+    public function it_can_create_a_compressed_snapshot_from_cli_param()
     {
         Artisan::call('snapshot:create', ['--compress' => true]);
 
@@ -37,4 +37,18 @@ public function it_can_create_a_compressed_snapshot()
 
         $this->assertNotEmpty(gzdecode($this->disk->get($fileName)));
     }
+
+    /** @test */
+    public function it_can_create_a_compressed_snapshot_from_config()
+    {
+        $this->app['config']->set('db-snapshots.compress', true);
+
+        Artisan::call('snapshot:create');
+
+        $fileName = Carbon::now()->format('Y-m-d_H-i-s').'.sql.gz';
+
+        $this->disk->assertExists($fileName);
+
+        $this->assertNotEmpty(gzdecode($this->disk->get($fileName)));
+    }
 }