use correct field on dependent fieldsets

[lisps]

when dependent fieldsets are used only the last field with the same name is taken.

@Klap-in @micgro42 can you have a look at it?

it is more or less used in mailaction to only get the correct fieldset. (https://github.com/splitbrain/dokuwiki-plugin-bureaucracy/blob/master/helper/actionmail.php#L105)

[Klap-in]

Can you give an example (the syntax) of a form that is fixed by this? That is easier testing.

[lisps]

<pagemod a>
  * @@var@@</pagemod>

<form>
select depends a|b|c
action pagemod _self a

fieldset Fieldset1 depends a 
Textbox  var =a

fieldset Fieldset2 depends b 
Textbox  var =b

fieldset Fieldset3 depends c 
Textbox  var =c 

Fieldset
submit
</form>

[Klap-in]

Hmm, the fieldset field sets all its containing fields already to hidden by itself. So no logic is required later. I think checking if $field->hidden is true is already enough.

(This means that the mail action can be simplified as well, but that is not scope of this PR)

[lisps]

sometimes its so easy 😉

[Klap-in]

Hehe, thanks! I will test it if I have some free time.

[Klap-in]

This solution doesn't yet prepare always replacement pairs (label-value patterns) for each field, because fields are skipped for closed/hidden fieldsets. While the original situation assumes that for all fields always such a pattern pair was created. Even when no value is given, a replacement pattern is needed to replace the placeholder with the Default value for a placeholder like: @@labelname|Default value@@.

A solution could be to fill the $this->patterns[$label] and $this->values[$label] with patterns for empty values by calling in prepareFieldReplacements() prepareFieldReplacement() with $value=null And later on use the updated code to override patterns of fields which has a non-empty value.

syntax that let reproduce this situation:

<pagemod a>
  * @@var@@
  * @@secondvar|Default1@@
  * @@thirdvar|Default2@@</pagemod>

<form>
select depends a|b|c
action pagemod _self a
Textbox thirdvar =d !

fieldset Fieldset1 depends a 
Textbox  var =a

fieldset Fieldset2 depends b 
Textbox  var =b
Textbox secondvar =e

fieldset Fieldset3 depends c 
Textbox  var =c 

Fieldset
submit
</form>