Skip to content
This repository was archived by the owner on Mar 28, 2022. It is now read-only.
This repository was archived by the owner on Mar 28, 2022. It is now read-only.

adaptiveOnsets(): N[] array has no purpose #87

@dpwe

Description

@dpwe

On lines like https://github.com/spotify/echoprint-codegen/blob/master/src/Fingerprint.cxx#L128
I see logic to set N[j] to the threshold at the most recent crossing of the envelope, but I don't see anywhere where N[j] is read back or used. I conclude it's vestigial and should be removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions