Skip to content

Scroll to last added dependency on dialog reopen #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Scroll to last added dependency on dialog reopen #1964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6584f92
1st refact code: relocate updateScroll
n4j1Br4ch1D Oct 30, 2025
452c2f1
feat(ui): scroll to last added dependency on dialog reopen
n4j1Br4ch1D Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions start-client/src/components/common/dependency/Dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,20 @@ function Dialog({ onClose }) {
setSelected(0)
setQuery('')
textFocus()
requestAnimationFrame(scrollToLastAddedDependency)
}

const onKeyUp = event => {
if (event.keyCode === 91 || event.keyCode === 93 || event.keyCode === 17) {
setMultiple(false)
}

const scrollToLastAddedDependency = () => {
const wrapperElement = get(wrapper, 'current')
const addedDependencies = wrapperElement.querySelectorAll('a.added')
if (!addedDependencies.length) return
const lastAddedDependency = addedDependencies[addedDependencies.length - 1]
const wrapperRect = wrapperElement.getBoundingClientRect()
const dependencyRect = lastAddedDependency.getBoundingClientRect()
wrapperElement.scrollBy({
top: dependencyRect.top - wrapperRect.top - 40,
behavior: 'smooth'
})
}

const updateScroll = () => {
Expand All @@ -139,6 +147,12 @@ function Dialog({ onClose }) {
}
}

const onKeyUp = event => {
if (event.keyCode === 91 || event.keyCode === 93 || event.keyCode === 17) {
setMultiple(false)
}
}

const onKeyDown = event => {
if (event.keyCode === 75 && (event.ctrlKey || event.metaKey)) {
onClose()
Expand Down