Skip to content

Commit 83c20b4

Browse files
committed
Adapt to changes in Spring Framework.
Test based on JNDI injection removed, along with the context configuration xml used by the test. The classes used for mocking the JNDI context are no longer part of Spring Framework. RequiredAnnotationBeanPostProcessor removed from configuration. It's no longer provided by Spring Framework. Closes #2385
1 parent 521adb1 commit 83c20b4

File tree

3 files changed

+3
-65
lines changed

3 files changed

+3
-65
lines changed

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/support/DefaultJpaContextIntegrationTests.java

Lines changed: 3 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -16,38 +16,30 @@
1616
package org.springframework.data.jpa.repository.support;
1717

1818
import static org.assertj.core.api.Assertions.*;
19-
import static org.mockito.Mockito.*;
2019

21-
import java.util.Arrays;
22-
import java.util.HashSet;
23-
24-
import javax.naming.NamingException;
2520
import jakarta.persistence.EntityManager;
2621
import jakarta.persistence.EntityManagerFactory;
27-
import javax.sql.DataSource;
22+
23+
import java.util.Arrays;
24+
import java.util.HashSet;
2825

2926
import org.junit.jupiter.api.BeforeAll;
3027
import org.junit.jupiter.api.BeforeEach;
3128
import org.junit.jupiter.api.Test;
32-
3329
import org.springframework.beans.factory.annotation.Autowired;
3430
import org.springframework.context.ConfigurableApplicationContext;
3531
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
3632
import org.springframework.context.annotation.Bean;
3733
import org.springframework.context.annotation.ComponentScan;
3834
import org.springframework.context.annotation.ComponentScan.Filter;
3935
import org.springframework.context.annotation.FilterType;
40-
import org.springframework.context.support.ClassPathXmlApplicationContext;
4136
import org.springframework.data.jpa.domain.sample.Category;
4237
import org.springframework.data.jpa.domain.sample.User;
4338
import org.springframework.data.jpa.infrastructure.HibernateTestUtils;
4439
import org.springframework.data.jpa.repository.JpaContext;
4540
import org.springframework.data.jpa.repository.config.EnableJpaRepositories;
4641
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder;
4742
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType;
48-
import org.springframework.jndi.JndiObjectFactoryBean;
49-
import org.springframework.mock.jndi.ExpectedLookupTemplate;
50-
import org.springframework.mock.jndi.SimpleNamingContextBuilder;
5143
import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean;
5244
import org.springframework.stereotype.Component;
5345

@@ -132,21 +124,6 @@ void bootstrapsDefaultJpaContextInSpringContainer() {
132124
context.close();
133125
}
134126

135-
@Test // DATAJPA-813
136-
void bootstrapsDefaultJpaContextInSpringContainerWithEntityManagerFromJndi() throws Exception {
137-
138-
SimpleNamingContextBuilder builder = SimpleNamingContextBuilder.emptyActivatedContextBuilder();
139-
builder.bind("some/EMF", createEntityManagerFactory("spring-data-jpa"));
140-
builder.bind("some/other/Component", new Object());
141-
142-
ConfigurableApplicationContext context = new ClassPathXmlApplicationContext("config/jpa-context-with-jndi.xml");
143-
ApplicationComponent component = context.getBean(ApplicationComponent.class);
144-
145-
assertThat(component.context).isNotNull();
146-
147-
context.close();
148-
}
149-
150127
@EnableJpaRepositories
151128
@ComponentScan(includeFilters = @Filter(type = FilterType.ASSIGNABLE_TYPE, value = ApplicationComponent.class),
152129
useDefaultFilters = false)
@@ -157,19 +134,6 @@ public LocalContainerEntityManagerFactoryBean entityManagerFactory() {
157134
return createEntityManagerFactoryBean("spring-data-jpa");
158135
}
159136

160-
// A non-EntityManagerFactory JNDI object to make sure the detection doesn't include it
161-
// see DATAJPA-956
162-
@Bean
163-
public JndiObjectFactoryBean jndiObject() throws NamingException {
164-
165-
JndiObjectFactoryBean bean = new JndiObjectFactoryBean();
166-
167-
bean.setJndiName("some/DataSource");
168-
bean.setJndiTemplate(new ExpectedLookupTemplate("some/DataSource", mock(DataSource.class)));
169-
bean.setExpectedType(DataSource.class);
170-
171-
return bean;
172-
}
173137
}
174138

175139
@Component

spring-data-jpa/src/test/resources/application-context.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@
3939
<!-- Adds transaparent exception translation to the DAOs -->
4040
<bean class="org.springframework.dao.annotation.PersistenceExceptionTranslationPostProcessor" />
4141

42-
<!-- Adds dependency checks for setters annotated with @Required -->
43-
<bean class="org.springframework.beans.factory.annotation.RequiredAnnotationBeanPostProcessor" />
44-
4542
<bean id="expressionEvaluationContextProvider" class="org.springframework.data.repository.query.ExtensionAwareQueryMethodEvaluationContextProvider" autowire="constructor" />
4643

4744
<bean class="org.springframework.data.jpa.repository.support.EntityManagerBeanDefinitionRegistrarPostProcessor" />

spring-data-jpa/src/test/resources/config/jpa-context-with-jndi.xml

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)