Skip to content

Commit aaf92ab

Browse files
committed
NPE for request bodies with content that has media type MULTIPART_FORM_DATA_VALUE. Fixes #1804
1 parent 7ad1bb7 commit aaf92ab

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

springdoc-openapi-common/src/main/java/org/springdoc/core/AbstractRequestService.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ protected AbstractRequestService(GenericParameterService parameterBuilder, Reque
198198
this.localSpringDocParameterNameDiscoverer = localSpringDocParameterNameDiscoverer;
199199
this.defaultFlatParamObject = parameterBuilder.getPropertyResolverUtils().getSpringDocConfigProperties().isDefaultFlatParamObject();
200200
this.defaultSupportFormData = parameterBuilder.getPropertyResolverUtils().getSpringDocConfigProperties().isDefaultSupportFormData();
201-
202201
}
203202

204203
/**
@@ -330,19 +329,18 @@ else if (!RequestMethod.GET.equals(requestMethod)) {
330329
if (defaultSupportFormData && requestBody != null
331330
&& requestBody.getContent() != null
332331
&& requestBody.getContent().containsKey(org.springframework.http.MediaType.MULTIPART_FORM_DATA_VALUE)) {
333-
io.swagger.v3.oas.models.media.Schema<?> mergedSchema = requestBodyInfo.getMergedSchema();
334332
Iterator<Entry<String, Parameter>> it = map.entrySet().iterator();
335333
while (it.hasNext()) {
336334
Entry<String, Parameter> entry = it.next();
337335
Parameter parameter = entry.getValue();
338336
if (!ParameterIn.PATH.toString().equals(parameter.getIn())) {
339-
io.swagger.v3.oas.models.media.Schema<?> itemSchema = new io.swagger.v3.oas.models.media.Schema() ;
337+
io.swagger.v3.oas.models.media.Schema<?> itemSchema = new io.swagger.v3.oas.models.media.Schema<>() ;
340338
itemSchema.setName(entry.getKey());
341339
itemSchema.setDescription(parameter.getDescription());
342340
itemSchema.setDeprecated(parameter.getDeprecated());
343341
if (parameter.getExample() != null)
344342
itemSchema.setExample(parameter.getExample());
345-
mergedSchema.addProperty(entry.getKey(), itemSchema);
343+
requestBodyInfo.addProperties(entry.getKey(), itemSchema);
346344
it.remove();
347345
}
348346
}

0 commit comments

Comments
 (0)