From 06be654219c427f6dd99dd74951e50abf786f56a Mon Sep 17 00:00:00 2001 From: Stuart Robson Date: Tue, 10 Jan 2023 11:38:25 +0000 Subject: [PATCH 1/2] fix: updates compiled design tokens Sass variable names There are two outliers from a recent name spacing change for design tokens where we went from tokens-- to t- to align with how we namespace components. --- context/brand-context/HISTORY.md | 2 ++ context/brand-context/default/scss/40-base/block-spacing.scss | 4 ++-- context/brand-context/package.json | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/context/brand-context/HISTORY.md b/context/brand-context/HISTORY.md index db473c83f..894d57919 100644 --- a/context/brand-context/HISTORY.md +++ b/context/brand-context/HISTORY.md @@ -1,5 +1,7 @@ # History +## 31.0.1 (2023-01-10) + * FIX: updates the block spacing variable naming to use the correct token variable. ## 31.0.0 (2023-01-04) * Reduce scope of block spacing * NOTE: This version replaces all versions >= 28.0.0 diff --git a/context/brand-context/default/scss/40-base/block-spacing.scss b/context/brand-context/default/scss/40-base/block-spacing.scss index a807786f4..3ed6927e8 100644 --- a/context/brand-context/default/scss/40-base/block-spacing.scss +++ b/context/brand-context/default/scss/40-base/block-spacing.scss @@ -10,14 +10,14 @@ h1, h2, h3, h4, h5 { // The specificity is that of one element selector. :is(p, ol, ul, dl, figure, blockquote, form, pre, table, img, video, aside, section, article) + :is(p, ol, ul, dl, figure, blockquote, form, pre, table, img, video, aside, section, article) { - margin-block-start: $tokens--typography-block-spacing-medium; + margin-block-start: $$t-typography-block-spacing-medium; } //
elements found among basic semantic content likely need similar margin applied. // The specificity is that of two element selectors; a utility class can override it :is(p, ol, ul, dl, figure, blockquote, pre, table, img, video) + div, div + :is(p, ol, ul, dl, figure, blockquote, pre, table, img, video) { - margin-block-start: $tokens--typography-block-spacing-medium; + margin-block-start: $$t-typography-block-spacing-medium; } // Headings have differing margins to other flow elements. diff --git a/context/brand-context/package.json b/context/brand-context/package.json index 4983ae2a0..99445cc96 100644 --- a/context/brand-context/package.json +++ b/context/brand-context/package.json @@ -1,6 +1,6 @@ { "name": "@springernature/brand-context", - "version": "31.0.0", + "version": "31.0.1", "license": "MIT", "description": "Bootstrapping for all components and products", "keywords": [], From 39a2c7412b4d2e59f4a677e07d2497ba7bd6a2c8 Mon Sep 17 00:00:00 2001 From: Stuart Robson Date: Tue, 10 Jan 2023 14:42:32 +0000 Subject: [PATCH 2/2] corrects mis-duplciation of the dollar sign --- context/brand-context/default/scss/40-base/block-spacing.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/context/brand-context/default/scss/40-base/block-spacing.scss b/context/brand-context/default/scss/40-base/block-spacing.scss index 3ed6927e8..867500afd 100644 --- a/context/brand-context/default/scss/40-base/block-spacing.scss +++ b/context/brand-context/default/scss/40-base/block-spacing.scss @@ -10,14 +10,14 @@ h1, h2, h3, h4, h5 { // The specificity is that of one element selector. :is(p, ol, ul, dl, figure, blockquote, form, pre, table, img, video, aside, section, article) + :is(p, ol, ul, dl, figure, blockquote, form, pre, table, img, video, aside, section, article) { - margin-block-start: $$t-typography-block-spacing-medium; + margin-block-start: $t-typography-block-spacing-medium; } //
elements found among basic semantic content likely need similar margin applied. // The specificity is that of two element selectors; a utility class can override it :is(p, ol, ul, dl, figure, blockquote, pre, table, img, video) + div, div + :is(p, ol, ul, dl, figure, blockquote, pre, table, img, video) { - margin-block-start: $$t-typography-block-spacing-medium; + margin-block-start: $t-typography-block-spacing-medium; } // Headings have differing margins to other flow elements.