Skip to content

Commit bbceaf6

Browse files
Shreyas SrivathsaShreyas Srivathsa
authored andcommitted
Update dockerfile for processor (change JAVA_HOME). Update workflow to use env vars for image tags
1 parent 9368634 commit bbceaf6

File tree

2 files changed

+19
-9
lines changed

2 files changed

+19
-9
lines changed

.github/workflows/build-and-push.yaml

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ on:
77
pull_request:
88
branches: [ "master" ]
99

10+
# update image tags based on update to each component here
11+
env:
12+
PRODUCER_IMAGE: producer:1.0.0
13+
PROCESSOR_IMAGE: processor:1.0.0
14+
GRPC_SERVER_IMAGE: grpc-server:1.0.0
15+
GRPC_CLIENT_IMAGE: grpc-client:1.0.0
16+
1017
jobs:
1118

1219
# each job:
@@ -26,9 +33,9 @@ jobs:
2633
- name: Login to dockerhub
2734
run: echo "${{ secrets.DOCKERHUB_TOKEN }}" | docker login docker.io -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
2835
- name: Build the producer image
29-
run: docker build -f deploy/producer/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/producer:1.0.0 .
36+
run: docker build -f deploy/producer/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.PRODUCER_IMAGE}} .
3037
- name: Push the producer image
31-
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/producer:1.0.0
38+
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.PRODUCER_IMAGE}}
3239

3340
build-and-push-processor:
3441
runs-on: ubuntu-latest
@@ -38,9 +45,9 @@ jobs:
3845
- name: Login to dockerhub
3946
run: echo "${{ secrets.DOCKERHUB_TOKEN }}" | docker login docker.io -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
4047
- name: Build the processor image
41-
run: docker build -f deploy/processor/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/processor:1.0.0 .
48+
run: docker build -f deploy/processor/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.PROCESSOR_IMAGE}} .
4249
- name: Push the processor image
43-
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/processor:1.0.0
50+
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.PROCESSOR_IMAGE}}
4451

4552
build-and-push-grpc-server:
4653
runs-on: ubuntu-latest
@@ -50,9 +57,9 @@ jobs:
5057
- name: Login to dockerhub
5158
run: echo "${{ secrets.DOCKERHUB_TOKEN }}" | docker login docker.io -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
5259
- name: Build the server image
53-
run: docker build -f deploy/server/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/grpc-server:1.0.0 .
60+
run: docker build -f deploy/server/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.GRPC_SERVER_IMAGE}} .
5461
- name: Push the server image
55-
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/grpc-server:1.0.0
62+
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.GRPC_SERVER_IMAGE}}
5663

5764
build-and-push-grpc-client:
5865
runs-on: ubuntu-latest
@@ -62,6 +69,6 @@ jobs:
6269
- name: Login to dockerhub
6370
run: echo "${{ secrets.DOCKERHUB_TOKEN }}" | docker login docker.io -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
6471
- name: Build the client image
65-
run: docker build -f deploy/client/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/grpc-client:1.0.0 .
72+
run: docker build -f deploy/client/Dockerfile -t docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.GRPC_CLIENT_IMAGE}} .
6673
- name: Push the client image
67-
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/grpc-client:1.0.0
74+
run: docker push docker.io/${{ secrets.DOCKERHUB_USERNAME }}/${{env.GRPC_CLIENT_IMAGE}}

deploy/processor/Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ ENV PYTHONUNBUFFERED=1
1212

1313
# install java and set java home (required for spark)
1414
RUN apt-get update && apt-get install -y openjdk-21-jre-headless && apt-get clean
15-
ENV JAVA_HOME=/usr/lib/jvm/java-21-openjdk-arm64
15+
# use arm64 if building the image on a mac with apple silicon
16+
#ENV JAVA_HOME=/usr/lib/jvm/java-21-openjdk-arm64
17+
# for intel/amd use the following line instead
18+
ENV JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64
1619
ENV PATH="$JAVA_HOME/bin:$PATH"
1720

1821
WORKDIR /app

0 commit comments

Comments
 (0)