Merge pull request #31 from ssanderson/fix-default-property

Fix default property

Author: Scott Sanderson

interface/default.py

@@ -52,6 +52,9 @@ def non_member_attributes(defaults, members):
                 # staticmethods can't use attributes of the interface.
                 continue
 
+            elif isinstance(impl, property):
+                impl = impl.fget
+
             self_name = TypedSignature(impl).first_argument_name
             if self_name is None:
                 # No parameters.
@@ -73,13 +76,20 @@ def accessed_attributes_of_local(f, local_name):
         The analysis performed by this function is conservative, meaning that
         it's not guaranteed to find **all** attributes used.
         """
+        try:
+            instrs = dis.get_instructions(f)
+        except TypeError:
+            # Got a default wrapping an object that's not a python function. Be
+            # conservative and assume this is safe.
+            return set()
+
         used = set()
         # Find sequences of the form: LOAD_FAST(local_name), LOAD_ATTR(<name>).
         # This will find all usages of the form ``local_name.<name>``.
         #
         # It will **NOT** find usages in which ``local_name`` is aliased to
         # another name.
-        for first, second in sliding_window(dis.get_instructions(f), 2):
+        for first, second in sliding_window(instrs, 2):
             if first.opname == 'LOAD_FAST' and first.argval == local_name:
                 if second.opname in ('LOAD_ATTR', 'LOAD_METHOD', 'STORE_ATTR'):
                     used.add(second.argval)

interface/tests/test_interface.py

@@ -528,6 +528,29 @@ def method2(self):
     assert C().has_default() == 3
 
 
+def test_default_property():
+
+    class IFace(Interface):  # pragma: nocover
+
+        @default
+        @property
+        def default_prop(self):
+            return True
+
+    class C(implements(IFace)):  # pragma: nocover
+        pass
+
+    assert C().default_prop
+
+    class D(implements(IFace)):
+
+        @property
+        def default_prop(self):
+            return False
+
+    assert not D().default_prop
+
+
 def test_override_default():
 
     class IFace(Interface):  # pragma: nocover

setup.py

@@ -30,7 +30,7 @@ def install_requires():
 
 setup(
     name='python-interface',
-    version='1.5.0',
+    version='1.5.2',
     description="Pythonic Interface definitions",
     author="Scott Sanderson",
     author_email="scott.b.sanderson90@gmail.com",