fix: ensure max_connection accepts default/None

Author: Yuri Zmytrakov

stac_fastapi/core/stac_fastapi/core/redis_utils.py

@@ -2,7 +2,7 @@
 
 import json
 import logging
-from typing import List, Optional, Tuple
+from typing import Any, List, Optional, Tuple
 from urllib.parse import parse_qs, urlencode, urlparse, urlunparse
 
 from pydantic import field_validator
@@ -21,7 +21,7 @@ class RedisSentinelSettings(BaseSettings):
     REDIS_SENTINEL_MASTER_NAME: str = "master"
     REDIS_DB: int = 15
 
-    REDIS_MAX_CONNECTIONS: int = 10
+    REDIS_MAX_CONNECTIONS: int | None = 10
     REDIS_RETRY_TIMEOUT: bool = True
     REDIS_DECODE_RESPONSES: bool = True
     REDIS_CLIENT_NAME: str = "stac-fastapi-app"
@@ -36,13 +36,18 @@ def validate_db_sentinel(cls, v: int) -> int:
             raise ValueError("REDIS_DB must be a positive integer")
         return v
 
-    @field_validator("REDIS_MAX_CONNECTIONS")
+    @field_validator("REDIS_MAX_CONNECTIONS", mode="before")
     @classmethod
-    def validate_max_connections_sentinel(cls, v: int) -> int:
-        """Validate REDIS_MAX_CONNECTIONS is at least 1."""
-        if v < 1:
-            raise ValueError("REDIS_MAX_CONNECTIONS must be at least 1")
-        return v
+    def validate_max_connections_sentinel(cls, v: Any) -> Optional[int]:
+        """Validate REDIS_MAX_CONNECTIONS."""
+        if v is None or v == "":
+            return None
+        if isinstance(v, str) and v.lower() in ("none", "null"):
+            return None
+        try:
+            return int(v)
+        except (ValueError, TypeError):
+            raise ValueError("Invalid value for REDIS_MAX_CONNECTIONS")
 
     @field_validator("REDIS_HEALTH_CHECK_INTERVAL")
     @classmethod
@@ -111,7 +116,7 @@ class RedisSettings(BaseSettings):
     REDIS_PORT: int = 6379
     REDIS_DB: int = 15
 
-    REDIS_MAX_CONNECTIONS: int = 10
+    REDIS_MAX_CONNECTIONS: int | None = 10
     REDIS_RETRY_TIMEOUT: bool = True
     REDIS_DECODE_RESPONSES: bool = True
     REDIS_CLIENT_NAME: str = "stac-fastapi-app"
@@ -134,13 +139,18 @@ def validate_db_standalone(cls, v: int) -> int:
             raise ValueError("REDIS_DB must be a positive integer")
         return v
 
-    @field_validator("REDIS_MAX_CONNECTIONS")
+    @field_validator("REDIS_MAX_CONNECTIONS", mode="before")
     @classmethod
-    def validate_max_connections_standalone(cls, v: int) -> int:
-        """Validate REDIS_MAX_CONNECTIONS is at least 1."""
-        if v < 1:
-            raise ValueError("REDIS_MAX_CONNECTIONS must be at least 1")
-        return v
+    def validate_max_connections_standalone(cls, v: Any) -> Optional[int]:
+        """Validate REDIS_MAX_CONNECTIONS."""
+        if v is None or v == "":
+            return None
+        if isinstance(v, str) and v.lower() in ("none", "null"):
+            return None
+        try:
+            return int(v)
+        except (ValueError, TypeError):
+            raise ValueError("Invalid value for REDIS_MAX_CONNECTIONS")
 
     @field_validator("REDIS_HEALTH_CHECK_INTERVAL")
     @classmethod