Skip to content

Commit 09378f1

Browse files
jhrozekclaude
andcommitted
Clarify CLI and K8s static mode share same code path
CLI mode and K8s static mode both use one-time discovery at startup with immutableRegistry. Only K8s dynamic mode adds controller-runtime complexity. This simplifies implementation since CLI and K8s static share identical vMCP binary behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 470f669 commit 09378f1

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

docs/proposals/THV-2884-vmcp-k8s-aware-refactor.md

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,10 +252,23 @@ existing sessions would have stale information if these changed dynamically.
252252

253253
### CLI Mode
254254

255-
CLI mode should remain static with one-time discovery at startup. Local
256-
development sessions are typically short-lived, and adding dynamic discovery
257-
to CLI would add complexity for limited benefit. This can be revisited as a
258-
separate work item if there's demand.
255+
CLI mode remains static with one-time discovery at startup. This is the same
256+
code path as K8s static mode - both read configuration at startup and use the
257+
immutableRegistry. The only difference is the config source:
258+
259+
| Mode | Config Source | Secret Source |
260+
|------|---------------|---------------|
261+
| CLI | User-provided YAML file | Environment variables |
262+
| K8s Static | Operator-generated ConfigMap | Operator-mounted env vars |
263+
| K8s Dynamic | Minimal ConfigMap + runtime discovery | K8s API (Secrets) |
264+
265+
This shared code path simplifies the implementation - CLI mode and K8s static
266+
mode use identical vMCP binary behavior. Only K8s dynamic mode adds the
267+
controller-runtime and informer complexity.
268+
269+
Dynamic discovery for CLI would require Docker events integration or polling,
270+
which adds complexity for limited benefit in short-lived dev sessions. This can
271+
be revisited as a separate work item if there's demand.
259272

260273
## Implementation
261274

0 commit comments

Comments
 (0)