From 893944a251442e0167311b2660d3214fd869bce3 Mon Sep 17 00:00:00 2001
From: Carlos Rodriguez <carlos_eduardo309@hotmail.com>
Date: Sat, 25 Nov 2023 19:34:12 +1100
Subject: [PATCH] added events enum, updated client.ts to manage events better

---
 __tests__/api/client.test.tsx | 45 +++++++++++++++++++++++++++++++++++
 src/client.ts                 | 10 +++++++-
 src/constants.ts              |  5 ++++
 3 files changed, 59 insertions(+), 1 deletion(-)

diff --git a/__tests__/api/client.test.tsx b/__tests__/api/client.test.tsx
index 394f2bdc..a2431100 100644
--- a/__tests__/api/client.test.tsx
+++ b/__tests__/api/client.test.tsx
@@ -161,6 +161,51 @@ describe('onChangeClientState', () => {
     });
   });
 
+  describe('Callbacks', () => {
+    it('Verify that callback onload is triggered', async () => {
+      const onChange = vi.fn();
+      let obj = { nested: { loaded: false, error: false } };
+
+      let onLoad = () => {
+        obj.nested.loaded = true;
+      };
+
+      const onError = () => {
+        obj.nested.error = true;
+      };
+
+      render(
+        <div>
+          <Helmet onChangeClientState={onChange}>
+            <title>Main Title</title>
+            <script
+              src="http://localhost/test.js"
+              type="text/javascript"
+              onload={onLoad} // eslint-disable-line
+              onError={onError}
+            />
+          </Helmet>
+        </div>
+      );
+
+      const newState = onChange.mock.calls[0][0];
+      expect(onChange).toHaveBeenCalled();
+      expect(onChange.mock.calls).toHaveLength(1);
+      expect(newState).toEqual(expect.objectContaining({ title: 'Main Title' }));
+      expect(typeof newState.scriptTags[0].onload).toEqual('function');
+      await new Promise(resolve =>
+        setInterval(() => {
+          // Simulate script load
+          newState.scriptTags[0].onload();
+          if (obj.nested.loaded) {
+            resolve(true);
+          }
+        }, 100)
+      );
+      expect(obj.nested).toEqual({ loaded: true, error: false });
+    });
+  });
+
   // it('calls the deepest defined callback with the deepest state', () => {
   //   const onChange = vi.fn();
   //   render(
diff --git a/src/client.ts b/src/client.ts
index 7a698b8b..cda014be 100644
--- a/src/client.ts
+++ b/src/client.ts
@@ -1,4 +1,4 @@
-import { HELMET_ATTRIBUTE, TAG_NAMES, TAG_PROPERTIES } from './constants';
+import { HELMET_ATTRIBUTE, TAG_EVENTS, TAG_NAMES, TAG_PROPERTIES } from './constants';
 import type { Attributes, StateUpdate, TagList } from './types';
 import { flattenArray } from './utils';
 
@@ -36,6 +36,14 @@ const updateTags = (type: string, tags: HTMLElement[]) => {
               // @ts-ignore
               newElement.appendChild(document.createTextNode(tag.cssText));
             }
+          } else if (
+            (TAG_EVENTS.ON_LOAD === attribute || TAG_EVENTS.ON_ERROR === attribute) &&
+            typeof tag[attribute] === 'function' &&
+            newElement instanceof HTMLScriptElement
+          ) {
+            const attr = attribute as keyof HTMLElement;
+            const value = typeof tag[attr] === 'undefined' ? '' : tag[attr];
+            newElement[attribute] = value as any;
           } else {
             const attr = attribute as keyof HTMLElement;
             const value = typeof tag[attr] === 'undefined' ? '' : tag[attr];
diff --git a/src/constants.ts b/src/constants.ts
index 401f0ea7..dc2f6948 100644
--- a/src/constants.ts
+++ b/src/constants.ts
@@ -17,6 +17,11 @@ export enum ATTRIBUTE_NAMES {
   TITLE = 'titleAttributes',
 }
 
+export enum TAG_EVENTS {
+  ON_LOAD = 'onload',
+  ON_ERROR = 'onerror',
+}
+
 export enum TAG_NAMES {
   BASE = 'base',
   BODY = 'body',