From 89e9d29a0f98c73c2fd24741a5578992bcf2d817 Mon Sep 17 00:00:00 2001 From: Jason Gill Date: Mon, 8 Jan 2024 13:30:41 -0700 Subject: [PATCH 1/2] Update Dispatcher.tsx --- src/Dispatcher.tsx | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/Dispatcher.tsx b/src/Dispatcher.tsx index 1a248fa6..396d65ff 100644 --- a/src/Dispatcher.tsx +++ b/src/Dispatcher.tsx @@ -27,16 +27,6 @@ export default class HelmetDispatcher extends Component { return !shallowEqual(nextProps, this.props); } - componentDidUpdate() { - this.emitChange(); - } - - componentWillUnmount() { - const { helmetInstances } = this.props.context; - helmetInstances.remove(this); - this.emitChange(); - } - emitChange() { const { helmetInstances, setHelmet } = this.props.context; let serverState = null; From 99cb9a8b4aeef0414b688757851ef79be54a0176 Mon Sep 17 00:00:00 2001 From: Jason Gill Date: Mon, 8 Jan 2024 13:41:30 -0700 Subject: [PATCH 2/2] fix: restore componentDidUpdate unit tests rely on this, doesn't seem to affect the NextJS issue so returning it to code. --- src/Dispatcher.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Dispatcher.tsx b/src/Dispatcher.tsx index 396d65ff..a22eee24 100644 --- a/src/Dispatcher.tsx +++ b/src/Dispatcher.tsx @@ -27,6 +27,10 @@ export default class HelmetDispatcher extends Component { return !shallowEqual(nextProps, this.props); } + componentDidUpdate() { + this.emitChange(); + } + emitChange() { const { helmetInstances, setHelmet } = this.props.context; let serverState = null;