Some maintenance work:

* Fixed some Intellisense warnings.
* Corrected some comments.
* Obsoleted `InvoiceDescriptor::AddTradeeCharge`, because there's an identical function `InvoiceDescriptor::AddTradeCharge`. (Note the typo in "Tradee".)

Author: Dirksche

ZUGFeRD.Test/XRechnungUBLTests.cs

@@ -235,7 +235,7 @@ public void TestSkippingOfAllowanceChargeBasisAmount()
 
             InvoiceDescriptor loadedInvoice = InvoiceDescriptor.Load(ms);
 
-            Tax tax = loadedInvoice.Taxes.FirstOrDefault(t => t.TypeCode == TaxTypes.LOC);
+            Tax? tax = loadedInvoice.Taxes.FirstOrDefault(t => t.TypeCode == TaxTypes.LOC);
             Assert.IsNotNull(tax);
             Assert.AreEqual(basisAmount, tax.BasisAmount);
             Assert.AreEqual(percent, tax.Percent);

ZUGFeRD.Test/ZUGFeRDCrossVersionTests.cs

@@ -545,7 +545,8 @@ public void TestGrossPriceRepresentationForXRechnungAndNotXRechnungPositiveCase(
         {
             decimal grossPrice = 10.1m;
             decimal netPrice = 10.0m;
-            decimal discountPercent = 10.0m;
+            // Is currently unused, therefore commented out.
+            //decimal discountPercent = 10.0m;
             decimal discountAmount = 0.1m;
 
             InvoiceDescriptor desc = this._InvoiceProvider.CreateInvoice();
@@ -980,8 +981,9 @@ public void TestWithoutGrossQuantity(ZUGFeRDVersion version, ZUGFeRDFormats form
         [DataRow(ZUGFeRDVersion.Version23, ZUGFeRDFormats.CII, Profile.Extended)]
         public void TestNulledGlobalIDScheme(ZUGFeRDVersion version, ZUGFeRDFormats format, Profile profile)
         {
-            decimal? desiredNetUnitQuantity = 20.0m;
-            decimal? desiredGrossUnitQuantity = 23.0m;
+            // Is currently unused, therefore commented out.
+            //decimal? desiredNetUnitQuantity = 20.0m;
+            //decimal? desiredGrossUnitQuantity = 23.0m;
 
             InvoiceDescriptor desc = new InvoiceProvider().CreateInvoice();
 

ZUGFeRD/InvoiceDescriptor.cs

@@ -1034,9 +1034,9 @@ public void SetContractReferencedDocument(string contractNo, DateTime? contractD
                 ID = contractNo,
                 IssueDateTime = contractDate
             };
-        } // !SetContractReferencedDocument()
-
-
+        } // !SetContractReferencedDocument()
+
+
         internal void _AddLogisticsServiceCharge(decimal amount, string description, TaxTypes? taxTypeCode, TaxCategoryCodes? taxCategoryCode, decimal taxPercent)
         {
             this.ServiceCharges.Add(new ServiceCharge()
@@ -1095,7 +1095,7 @@ public void AddTradeAllowance(decimal? basisAmount, CurrencyCodes currency, deci
         internal void _AddTradeAllowance(decimal? basisAmount, CurrencyCodes currency, decimal actualAmount,
                                          string reason, TaxTypes? taxTypeCode, TaxCategoryCodes? taxCategoryCode, decimal taxPercent,
                                          AllowanceReasonCodes? reasonCode = null)
-        {
+        {
             this.TradeAllowanceCharges.Add(new TradeAllowance()
             {
                 Reason = reason,
@@ -1142,7 +1142,7 @@ internal void _AddTradeCharge(decimal? basisAmount, CurrencyCodes currency, deci
                                       decimal? chargePercentage,
                                       string reason, TaxTypes? taxTypeCode, TaxCategoryCodes? taxCategoryCode, decimal taxPercent,
                                       ChargeReasonCodes? reasonCode = null)
-        {
+        {
             this.TradeAllowanceCharges.Add(new TradeCharge()
             {
                 Reason = reason,
@@ -1169,8 +1169,8 @@ internal void _AddTradeCharge(decimal? basisAmount, CurrencyCodes currency, deci
         /// </summary>
         /// <param name="basisAmount">Base amount for calculation</param>
         /// <param name="currency">Currency code</param>
-        /// <param name="actualAmount">Actual amount of allowance/charge</param>
-        /// <param name="reason">Reason for allowance/charge</param>
+        /// <param name="actualAmount">Actual amount of charge</param>
+        /// <param name="reason">Reason for charge</param>
         /// <param name="taxTypeCode">Type of tax</param>
         /// <param name="taxCategoryCode">Tax category</param>
         /// <param name="taxPercent">Tax percentage</param>
@@ -1213,11 +1213,11 @@ internal void _AddTradeCharge(decimal? basisAmount, CurrencyCodes currency, deci
         /// </summary>        
         /// <param name="basisAmount">Base amount (basis of allowance)</param>
         /// <param name="currency">Curency of the allowance</param>
-        /// <param name="actualAmount">Actual allowance charge amount</param>
-        /// <param name="chargePercentage">Actual allowance charge percentage</param>
+        /// <param name="actualAmount">Actual allowance amount</param>
+        /// <param name="chargePercentage">Actual allowance percentage</param>
         /// <param name="reason">Reason for the allowance</param>
-        /// <param name="taxTypeCode">VAT type code for document level allowance/ charge</param>
-        /// <param name="taxCategoryCode">VAT type code for document level allowance/ charge</param>
+        /// <param name="taxTypeCode">VAT type code for document level allowance</param>
+        /// <param name="taxCategoryCode">VAT type code for document level allowance</param>
         /// <param name="taxPercent">VAT rate for the allowance</param>
         /// <param name="reasonCode">Reason code for the allowance</param>
         public void AddTradeAllowance(decimal? basisAmount, CurrencyCodes currency, decimal actualAmount, decimal? chargePercentage, string reason, TaxTypes taxTypeCode, TaxCategoryCodes taxCategoryCode, decimal taxPercent, AllowanceReasonCodes? reasonCode = null)
@@ -1227,7 +1227,7 @@ public void AddTradeAllowance(decimal? basisAmount, CurrencyCodes currency, deci
 
 
         internal void _AddTradeAllowance(decimal? basisAmount, CurrencyCodes currency, decimal actualAmount, decimal? chargePercentage, string reason, TaxTypes? taxTypeCode, TaxCategoryCodes? taxCategoryCode, decimal taxPercent, AllowanceReasonCodes? reasonCode = null)
-        {
+        {
             this.TradeAllowanceCharges.Add(new TradeAllowance()
             {
                 Reason = reason,
@@ -1253,21 +1253,22 @@ internal void _AddTradeAllowance(decimal? basisAmount, CurrencyCodes currency, d
         /// BG-21
         /// Allowance represents a discount whereas charge represents a surcharge.
         /// </summary>        
-        /// <param name="basisAmount">Base amount (basis of allowance)</param>
-        /// <param name="currency">Curency of the allowance</param>
-        /// <param name="actualAmount">Actual allowance charge amount</param>
-        /// <param name="chargePercentage">Actual allowance charge percentage</param>
-        /// <param name="reason">Reason for the allowance</param>
-        /// <param name="taxTypeCode">VAT type code for document level allowance/ charge</param>
-        /// <param name="taxCategoryCode">VAT type code for document level allowance/ charge</param>
-        /// <param name="taxPercent">VAT rate for the allowance</param>
-        /// <param name="reasonCode">Reason code for the allowance</param>
+        /// <param name="basisAmount">Base amount (basis of charge)</param>
+        /// <param name="currency">Curency of the charge</param>
+        /// <param name="actualAmount">Actual charge amount</param>
+        /// <param name="chargePercentage">Actual charge percentage</param>
+        /// <param name="reason">Reason for the charge</param>
+        /// <param name="taxTypeCode">VAT type code for document level charge</param>
+        /// <param name="taxCategoryCode">VAT type code for document level charge</param>
+        /// <param name="taxPercent">VAT rate for the charge</param>
+        /// <param name="reasonCode">Reason code for the chargee/param>
+        [Obsolete("This function has a typo in the function name. Please use `AddTradeCharge` instead.", true)]
         public void AddTradeeCharge(decimal? basisAmount, CurrencyCodes currency, decimal actualAmount, decimal? chargePercentage, string reason, TaxTypes taxTypeCode, TaxCategoryCodes taxCategoryCode, decimal taxPercent, ChargeReasonCodes? reasonCode = null)
         {
             _AddTradeCharge(basisAmount, currency, actualAmount, chargePercentage, reason, taxTypeCode, taxCategoryCode, taxPercent, reasonCode);
-        } // !AddTradeCharge()
-
-
+        } // !AddTradeCharge()
+
+
         /// <summary>
         /// Returns all existing trade allowances
         ///
@@ -1302,6 +1303,7 @@ public IList<TradeCharge> GetTradeCharges()
         /// <param name="percentage">Optional percentage</param>
         /// <param name="baseAmount">Optional base amount</param>
         /// <param name="actualAmount">Optional actual amount</param>
+        /// <param name="maturityDate">Optional `DateTime?`</param>
         public void AddTradePaymentTerms(string description, DateTime? dueDate = null,
             PaymentTermsType? paymentTermsType = null, int? dueDays = null,
             decimal? percentage = null, decimal? baseAmount = null, decimal? actualAmount = null, DateTime? maturityDate = null)
@@ -1517,6 +1519,7 @@ private static IInvoiceDescriptorWriter _SelectInvoiceDescriptorWriter(ZUGFeRDVe
         /// <param name="version">ZUGFeRD version to use</param>
         /// <param name="profile">ZUGFeRD profile to use</param>
         /// <param name="format">Output format (CII or UBL)</param>
+        /// <param name="options">Optional `InvoiceFormatOptions`</param>
         public void Save(Stream stream, ZUGFeRDVersion version = ZUGFeRDVersion.Version23, Profile profile = Profile.Basic, ZUGFeRDFormats format = ZUGFeRDFormats.CII, InvoiceFormatOptions options = null)
         {
             this.Profile = profile;
@@ -1532,6 +1535,7 @@ public void Save(Stream stream, ZUGFeRDVersion version = ZUGFeRDVersion.Version2
         /// <param name="version">ZUGFeRD version to use</param>
         /// <param name="profile">ZUGFeRD profile to use</param>
         /// <param name="format">Output format (CII or UBL)</param>
+        /// <param name="options">Optional `InvoiceFormatOptions`</param>
         public void Save(string filename, ZUGFeRDVersion version = ZUGFeRDVersion.Version23, Profile profile = Profile.Basic, ZUGFeRDFormats format = ZUGFeRDFormats.CII, InvoiceFormatOptions options = null)
         {
             this.Profile = profile;
@@ -1598,9 +1602,9 @@ public TradeLineItem AddTradeLineCommentItem(string lineID, string comment, stri
             }
 
             item.AssociatedDocument.Notes.Add(new Note(
-                content: comment
-            // no subjectcode
-            // no contentcode
+                content: comment
+            // no subjectcode
+            // no contentcode
             ));
 
             this.TradeLineItems.Add(item);
@@ -1640,7 +1644,7 @@ public TradeLineItem AddTradeLineCommentItem(string lineID, string comment, stri
         public TradeLineItem AddTradeLineItem(string name,
                                     decimal netUnitPrice,
                                     QuantityCodes unitCode,
-                                    string description = null,
+                                    string description = null,
                                     decimal? unitQuantity = null,
                                     decimal? grossUnitPrice = null,
                                     decimal billedQuantity = 0,
@@ -1715,7 +1719,7 @@ public TradeLineItem AddTradeLineItem(string lineID,
                                     string name,
                                     decimal netUnitPrice,
                                     QuantityCodes unitCode,
-                                    string description = null,
+                                    string description = null,
                                     decimal? unitQuantity = null,
                                     decimal? grossUnitPrice = null,
                                     decimal billedQuantity = 0,
@@ -1777,7 +1781,7 @@ internal TradeLineItem _AddTradeLineItem(string lineID,
                                     string buyerOrderLineID = "", string buyerOrderID = "", DateTime? buyerOrderDate = null,
                                     DateTime? billingPeriodStart = null, DateTime? billingPeriodEnd = null
                                     )
-        {
+        {
             if (String.IsNullOrWhiteSpace(lineID))
             {
                 throw new ArgumentException("LineID cannot be Null or Empty");
@@ -2045,9 +2049,9 @@ public List<BankAccount> GetDebitorFinancialAccounts()
         public bool AnyDebitorFinancialAccount()
         {
             return this.DebitorBankAccounts?.Any() == true;
-        } // !AnyDebitorFinancialAccount()
-
-
+        } // !AnyDebitorFinancialAccount()
+
+
         /// <summary>
         /// Adds a receivable specified trade accounting account with ID and type code
         ///
@@ -2171,11 +2175,11 @@ public List<Note> GetNotes()
 
         private string _getNextLineId()
         {
-            int? highestLineId = this.GetTradeLineItems()?.Select(i =>
+            int? highestLineId = this.GetTradeLineItems()?.Select(i =>
             {
                 if (Int32.TryParse(i.AssociatedDocument?.LineID, out int id) == true)
                     return id;
-                else return 0;
+                else return 0;
             }
                 ).DefaultIfEmpty(0).Max() ?? 0;
             return highestLineId == null ? "1" : (highestLineId + 1).ToString();