Skip to content

"slower" and "faster" are inverted in the generated output #193

@mishaled

Description

@mishaled

When the time increases "faster" is written and when it decreases "slower".
It should be the other way around.
I believe this is the culprit-

)}ms | ${savedTime ? "(slower)" : "(faster)"}`;

Example of an output I got-

Previous-
│ 0 │ 'html-webpack-plugin' │ 176 │ '+121ms | (faster)' │
│ 1 │ 'babel-loader' │ 201591 │ '-20628ms | (slower)' │
│ 2 │ 'babel-loader,@sentry/webpack-plugin' │ 108 │ '-4ms | (slower)' │
│ 3 │ 'modules with no loaders' │ 30188 │ '+1697ms | (faster)' │
│ 4 │ 'mini-css-extract-plugin,css-loader,postcss-loader' │ 12075 │ '-5282ms | (slower)' │
│ 5 │ 'css-loader,postcss-loader' │ 6228 │ '-3644ms | (slower)' │
│ 6 │ 'file-loader' │ 1294 │ '-193ms | (slower)' │
│ 7 │ 'mini-css-extract-plugin,css-loader,postcss-loader,resolve-url-loader,less-loader' │ 60514 │ '-6399ms | (slower)' │
│ 8 │ 'css-loader,postcss-loader,resolve-url-loader,less-loader' │ 55457 │ '-7591ms | (slower)' │
│ 9 │ '@svgr/webpack,file-loader' │ 18742 │ '+2690ms | (faster)' │
│ 10 │ 'url-loader' │ 3915 │ '+157ms | (faster)' │

Current-
│ 0 │ 'html-webpack-plugin' │ 176 │ '+0ms | (faster)' │
│ 1 │ 'babel-loader' │ 204342 │ '+2751ms | (faster)' │
│ 2 │ 'babel-loader,@sentry/webpack-plugin' │ 120 │ '+12ms | (faster)' │
│ 3 │ 'modules with no loaders' │ 28532 │ '-1656ms | (slower)' │
│ 4 │ 'mini-css-extract-plugin,css-loader,postcss-loader' │ 9647 │ '-2428ms | (slower)' │
│ 5 │ 'css-loader,postcss-loader' │ 5664 │ '-564ms | (slower)' │
│ 6 │ 'file-loader' │ 1231 │ '-63ms | (slower)' │
│ 7 │ 'mini-css-extract-plugin,css-loader,postcss-loader,resolve-url-loader,less-loader' │ 54170 │ '-6344ms | (slower)' │
│ 8 │ 'css-loader,postcss-loader,resolve-url-loader,less-loader' │ 49302 │ '-6155ms | (slower)' │
│ 9 │ '@svgr/webpack,file-loader' │ 13021 │ '-5721ms | (slower)' │
│ 10 │ 'url-loader' │ 3460 │ '-455ms | (slower)' │

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions