fix: hardcode 'firefox' as container prefix for waterfox and librewolf #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibreWolf issue: https://codeberg.org/librewolf/issues/issues/2669 Temporary Containers Issue: stoically#335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Temporary Containers Automatic mode is not working on firefox forks which customize the value returned as the browser name.
The mismatch means the extension crashes when a new tab opens, an error prints out at the console and the container for the new tab is not created.
Solution
Check if the browser is WaterFox or LibreWolf and then hardcode
firefox-defaultas the container prefix.I think ideally we would query the browser for the default prefix name (but not sure how to do that as of now)
LibreWolf issue: https://codeberg.org/librewolf/issues/issues/2669
Temporary Containers Issue: #335