fix: use lodash setWith when target is an object (#102)

* fix: use lodash setWith when target is an object

* chore: lint fix

Author: Domagoj Kriskovic

src/__tests__/bundle.spec.ts

@@ -809,6 +809,72 @@ describe('bundleTargetPath()', () => {
     });
   });
 
+  it('should not convert object to array when using numeric keys', () => {
+    const result = bundleTarget({
+      document: {
+        openapi: '3.0.0',
+        paths: {
+          '/path': {
+            get: {
+              responses: {
+                '200': {
+                  content: {
+                    'application/json': {
+                      schema: {
+                        type: 'object',
+                        properties: {
+                          numModel: { $ref: '#/components/schemas/200' },
+                        },
+                      },
+                    },
+                  },
+                },
+              },
+            },
+          },
+        },
+        components: {
+          schemas: {
+            '200': {
+              title: '200',
+              type: 'object',
+              properties: { id: { type: 'string' } },
+            },
+          },
+        },
+        __target__: {
+          id: '?http-operation-id?',
+          method: 'get',
+          path: '/path',
+          responses: [
+            {
+              code: '200',
+              headers: [],
+              contents: [
+                {
+                  mediaType: 'application/json',
+                  schema: {
+                    type: 'object',
+                    properties: {
+                      numModel: { $ref: '#/components/schemas/200' },
+                    },
+                    $schema: 'http://json-schema.org/draft-07/schema#',
+                  },
+                  examples: [],
+                  encodings: [],
+                },
+              ],
+            },
+          ],
+        },
+      },
+      path: '#/__target__',
+      bundleRoot: '#/components/schemas',
+    });
+
+    expect(Array.isArray(result.components.schemas)).toBe(false);
+  });
+
   describe('when custom bundleRoot is provided', () => {
     it('should work', () => {
       const bundleRoot = '#/__custom-root__';

src/bundle.ts

@@ -1,4 +1,4 @@
-import { cloneDeep, get, has, set } from 'lodash';
+import { cloneDeep, get, has, set, setWith } from 'lodash';
 
 import { Dictionary, JsonPath } from '@stoplight/types';
 import { hasRef } from './hasRef';
@@ -114,7 +114,7 @@ const bundle = (document: unknown, bundleRoot: JsonPath, errorsRoot: JsonPath) =
             if (Array.isArray(target)) {
               set(bundledObj, inventoryPath, new Array(target.length).fill(null));
             } else if (typeof target === 'object') {
-              set(bundledObj, inventoryPath, {});
+              setWith(bundledObj, inventoryPath, {}, Object);
             }
 
             set(bundledObj, inventoryPath, bundled$Ref);