Tapioca doesn’t generate the expected types from `rbi/stripe/*`

[Tom-Bonnike]

Describe the bug

👋 As you know, the stripe-ruby gem ships .rbi files since v14; however when generating the RBI files via Tapioca, it doesn’t generate any signature except for params of each class’ def initialize… and, interestingly, the attributes of the Stripe::V2::Amount class?

For example, if you look at the PaymentIntent RBI, each attribute is properly typed, yet it’s not picked up by Tapioca. Any clue? Is it a problem with how the .rbi files are defined, or do you think it’s a bug in Tapioca?

From your README:

and to decrease Tapioca loading time we pack the gem with the combined RBI at rbi/stripe.rbi.

I can’t find this file? it’s only on the beta branch

While I’m at it, it’s super slow to re-generate the rbi for the gem… do you think it could be because of Shopify/tapioca#1361 / Shopify/tapioca#1285? I wonder if shipping the docs in the rbi files is useful; they’re already included in the actual gem, so they should be raised up in the editor when hovering anyway, no? I can create a separate issue for that if you think it’s worth it.

To Reproduce

1. Install the Stripe gem (v14 or v15 leads to the same issue)
2. Run bin/tapioca gem stripe to generate the RBI for the Stripe gem
3. Open the generated sorbet/rbi/gems/stripe@15.0.0.rbi; signatures are missing except for initialize methods.

Expected behavior

The full signatures should be generated by Sorbet.

Code snippets

OS

macOS

Language version

Ruby 3.3.7

Library version

stripe-ruby v15

API version

N/A

Additional context

No response

[Tom-Bonnike]

Ahh just saw stripe.rbi is only on the beta branch. Let me try v14.1.0-beta.1! that didn’t help.

[Tom-Bonnike]

Also just found out about Shopify/tapioca#2248, looks like it may well be a bug with Tapioca…

[helenye-stripe]

Hi! Sorry for the friction here. I'm going to work on adding annotations for our manually maintained portions of the SDK so we don't have to rely on Tapioca for generating the rest of the type annotations. I'll also make sure the combined spec comes out in the April release.

[Tom-Bonnike]

nice to hear! isn’t using Tapioca the only way to pull types from your rbi/stripe folder… unless we were to manually copy them? 🤔

[helenye-stripe]

Sorbet will still detect them (it should do so even now). Tapioca was necessary to generate types for the manually maintained code.

[Tom-Bonnike]

I think this is possibly not related to this issue, but it seems like nested Stripe Objects are not instantiated correctly, e.g. if you retrieve a Stripe::Account, the account.capabilities will be a simple Stripe::StripeObject instead of Stripe::Account::Capabilities.

So, with this example, the type defined here seems wrong, unless I’m missing something?

[helenye-stripe]

You are correct! I'll look into correcting that as well once we have cycles to revisit this.