EPIC: Add eslint-plugin-imports 💪

Author: robertrossmann

coding-styles/base.js

@@ -377,6 +377,9 @@ module.exports = {
     'wrap-iife': [1, 'inside'],
 
     // Enforce spacing around the * in `yield*` expressions
-    'yield-star-spacing': [1, 'after']
+    'yield-star-spacing': [1, 'after'],
+
+    // Enforces having an empty line after the last top-level import statement or require call
+    'import/newline-after-import': 1
   }
 }

environments/react/known-errors.js

@@ -61,6 +61,11 @@ module.exports = {
     // Prevent missing React when using JSX
     // When using JSX, <a /> expands to React.createElement("a"). Therefore the React variable must
     // be in scope.
-    'react/react-in-jsx-scope': 2
+    'react/react-in-jsx-scope': 2,
+
+    // Forbid Webpack loader syntax in imports
+    // This syntax is non-standard, so it couples the code to Webpack. The recommended way to
+    // specify Webpack loader configuration is in a Webpack configuration file.
+    'import/no-webpack-loader-syntax': 2
   }
 }

package.json

@@ -8,6 +8,7 @@
   },
   "contributors": [],
   "dependencies": {
+    "eslint-plugin-import": "^2.0.0",
     "eslint-plugin-react": "^6.3.0"
   },
   "engines": {},

standard/best-practices.js

@@ -278,6 +278,23 @@ module.exports = {
     // While there are no performance differences between the two approaches, the byte savings and
     // conciseness of the object literal form is what has made it the de facto way of creating new
     // objects.
-    'no-new-object': 1
+    'no-new-object': 1,
+
+    // Reports use of an exported name as the locally imported name of a default export
+    'import/no-named-as-default': 1,
+
+    // Reports use of an exported name as a property on the default export
+    // Accessing a property that has a name that is shared by an exported name from the same module
+    // is likely to be a mistake.
+    'import/no-named-as-default-member': 1,
+
+    // This rule reports any imports that come after non-import statements
+    'import/first': 1,
+
+    // Reports if a resolved path is imported more than once
+    'import/no-duplicates': 1,
+
+    // Ensure consistent use of file extension within the import path
+    'import/extensions': [1, 'never']
   }
 }

standard/known-errors.js

@@ -9,6 +9,14 @@
 'use strict'
 
 module.exports = {
+  plugins: [
+    'import'
+  ],
+
+  settings: {
+    'import/extensions': ['.js', 'jsx', '.es']
+  },
+
   rules: {
     // Disallow Assignment in Conditional Statements
     // This rule is aimed at eliminating ambiguous assignments in for, if, while, and do...while
@@ -327,6 +335,36 @@ module.exports = {
     }],
 
     // Disallow generator functions that do not have yield
-    'require-yield': 2
+    'require-yield': 2,
+
+    // Ensure an imported module can be resolved to a module on the local filesystem
+    'import/no-unresolved': [2, {
+      commonjs: true
+    }],
+
+    // Verifies that all named imports are part of the set of named exports in the referenced module
+    'import/named': 2,
+
+    // If a default import is requested, this rule will report if there is no default export in the
+    // imported module
+    'import/default': 2,
+
+    // Enforces names exist at the time they are dereferenced, when imported as a full namespace
+    'import/namespace': 2,
+
+    // Forbid import of modules using absolute paths
+    // Node.js allows the import of modules using an absolute path such as */home/xyz/file.js*. That
+    // is a bad practice as it ties the code using it to your computer.
+    'import/no-absolute-path': 2,
+
+    // Reports funny business with exports, like repeated exports of names or defaults
+    'import/export': 2,
+
+    // Forbid the use of extraneous packages
+    // Forbid the import of external modules that are not declared in package.json.
+    'import/no-extraneous-dependencies': 2,
+
+    // Forbid the use of mutable exports with var or let
+    'import/no-mutable-exports': 2
   }
 }