Skip to content

Commit 287e701

Browse files
authored
Merge pull request #448 from styleguidist/revert-441-master
Revert "Resolve issue with first displayName always being used"
2 parents 599668e + 142c759 commit 287e701

File tree

4 files changed

+1
-76
lines changed

4 files changed

+1
-76
lines changed

src/__tests__/data/StatelessDisplayNameMultipleDisplayNames.tsx

Lines changed: 0 additions & 22 deletions
This file was deleted.

src/__tests__/data/StatelessDisplayNameMultipleFnsOneDisplayName.tsx

Lines changed: 0 additions & 12 deletions
This file was deleted.

src/__tests__/parser.ts

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -989,32 +989,6 @@ describe('parser', () => {
989989
const [parsed] = parse(fixturePath('StatefulDisplayNameFolder/index'));
990990
assert.equal(parsed.displayName, 'StatefulDisplayNameFolder');
991991
});
992-
993-
it('should get all displayNames from single file when multiple functions have the property defined', () => {
994-
const [parsed1, parsed2, parsed3] = parse(
995-
fixturePath('StatelessDisplayNameMultipleDisplayNames')
996-
);
997-
998-
// parsed1.displayName === 'Button'?
999-
// parsed1.displayName === 'SubmitButton'?
1000-
// parsed1.displayName === 'ResetButton'?
1001-
1002-
assert.equal(parsed1.displayName, 'First');
1003-
assert.equal(parsed2.displayName, 'Second');
1004-
assert.equal(parsed3.displayName, 'Third');
1005-
});
1006-
1007-
it('should get all displayNames from single file when multiple functions have the property defined', () => {
1008-
const [parsed1, parsed2] = parse(
1009-
fixturePath('StatelessDisplayNameMultipleFnsOneDisplayName')
1010-
);
1011-
1012-
// parsed1.displayName === 'Button'?
1013-
// parsed2 is `undefined`?
1014-
1015-
assert.equal(parsed1.displayName, 'First');
1016-
assert.equal(parsed2.displayName, 'someSeparateFunction');
1017-
});
1018992
});
1019993

1020994
describe('Parser options', () => {

src/parser.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1200,26 +1200,11 @@ function getTextValueOfFunctionProperty(
12001200
.filter(statement => {
12011201
const expr = (statement as ts.ExpressionStatement)
12021202
.expression as ts.BinaryExpression;
1203-
1204-
/**
1205-
* Ensure the .displayName is for the currently processing function.
1206-
*
1207-
* This avoids the following situations:
1208-
*
1209-
* - A file has multiple functions, one has `.displayName`, and all
1210-
* functions ends up with that same `.displayName` value.
1211-
*
1212-
* - A file has multiple functions, each with a different
1213-
* `.displayName`, but the first is applied to all of them.
1214-
*/
1215-
const flowNodeNameEscapedText = (statement as any)?.flowNode?.node?.name
1216-
?.escapedText as false | ts.__String | undefined;
1217-
12181203
return (
12191204
expr.left &&
12201205
(expr.left as ts.PropertyAccessExpression).name &&
12211206
(expr.left as ts.PropertyAccessExpression).name.escapedText ===
1222-
(propertyName && flowNodeNameEscapedText === exp.escapedName)
1207+
propertyName
12231208
);
12241209
})
12251210
.filter(statement => {

0 commit comments

Comments
 (0)