perf: save one iteration

Author: juleswritescode

crates/pg_completions/src/providers/functions.rs

@@ -6,18 +6,15 @@ use crate::{
 pub fn complete_functions(ctx: &CompletionContext, builder: &mut CompletionBuilder) {
     let available_functions = &ctx.schema_cache.functions;
 
-    let completion_items: Vec<CompletionItem> = available_functions
-        .iter()
-        .map(|foo| CompletionItem {
+    for foo in available_functions {
+        let item = CompletionItem {
             label: foo.name.clone(),
             score: CompletionRelevanceData::Function(foo).get_score(ctx),
             description: format!("Schema: {}", foo.schema),
             preselected: false,
             kind: CompletionItemKind::Function,
-        })
-        .collect();
+        };
 
-    for item in completion_items {
         builder.add_item(item);
     }
 }

crates/pg_completions/src/providers/tables.rs

@@ -8,18 +8,15 @@ use crate::{
 pub fn complete_tables(ctx: &CompletionContext, builder: &mut CompletionBuilder) {
     let available_tables = &ctx.schema_cache.tables;
 
-    let completion_items: Vec<CompletionItem> = available_tables
-        .iter()
-        .map(|table| CompletionItem {
+    for table in available_tables {
+        let item = CompletionItem {
             label: table.name.clone(),
             score: CompletionRelevanceData::Table(table).get_score(ctx),
             description: format!("Schema: {}", table.schema),
             preselected: false,
             kind: CompletionItemKind::Table,
-        })
-        .collect();
+        };
 
-    for item in completion_items {
         builder.add_item(item);
     }
 }