Skip to content

Commit 9fe3db5

Browse files
authored
type check for reactive declaration (#335)
* type check for reactive declaration * Revert "type check for reactive declaration" This reverts commit a600efd. * type check for reactive declaration * skip format related code
1 parent 046501a commit 9fe3db5

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

packages/svelte2tsx/src/svelte2tsx.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,9 @@ function processInstanceScriptContent(str: MagicString, script: Node): InstanceS
795795
// declare implicit reactive variables we found in the script
796796
for (const [name, pos] of implicitTopLevelNames.entries()) {
797797
if (!rootScope.declared.has(name)) {
798-
str.prependRight(pos + astOffset, `;let ${name}; `);
798+
// remove '$:' label
799+
str.remove(pos + astOffset, pos + astOffset+2);
800+
str.prependRight(pos + astOffset, `let `);
799801
}
800802
}
801803

packages/svelte2tsx/test/sourcemaps/let.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<></>;function render() {
22

3-
;let selected; $: selected = __sveltets_invalidate(() => lookup.get(slug));
3+
let selected = __sveltets_invalidate(() => lookup.get(slug));
44
;
55
<>
66
</>

packages/svelte2tsx/test/sourcemaps/repl.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@
6969
// here statically
7070
const tutorial_repo_link = 'https://github.com/sveltejs/svelte/tree/master/site/content/tutorial';
7171

72-
;let selected; $: selected = __sveltets_invalidate(() => lookup.get(slug));
73-
;let improve_link; $: improve_link = __sveltets_invalidate(() => `${tutorial_repo_link}/${selected.chapter.section_dir}/${selected.chapter.chapter_dir}`);
72+
let selected = __sveltets_invalidate(() => lookup.get(slug));
73+
let improve_link = __sveltets_invalidate(() => `${tutorial_repo_link}/${selected.chapter.section_dir}/${selected.chapter.chapter_dir}`);
7474

7575
const clone = file => ({
7676
name: file.name,
@@ -85,7 +85,7 @@
8585
});
8686
}}
8787

88-
;let mobile; $: mobile = __sveltets_invalidate(() => width < 768);
88+
let mobile = __sveltets_invalidate(() => width < 768);
8989

9090
function reset() {
9191
repl.update({

packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-object/expected.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<></>;function render() {
22

33

4-
;let b; $: b = __sveltets_invalidate(() => ({ a: 1 }));
4+
let b = __sveltets_invalidate(() => ({ a: 1 }));
55
;
66
<></>
77
return { props: {}, slots: {}, getters: {} }}

packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare/expected.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<></>;function render() {
22

33

4-
;let b; $: b = __sveltets_invalidate(() => 7);
4+
let b = __sveltets_invalidate(() => 7);
55

66
let a;
77
$: a = __sveltets_invalidate(() => 5);

0 commit comments

Comments
 (0)