fix: eslint and typescript issues after upgrade

Author: swashata

package.json

@@ -39,7 +39,8 @@
     "build": "lerna run build",
     "plop": "plop",
     "lerna": "lerna",
-    "nuke": "rm -r node_modules; for d in packages/*/node_modules; do echo $d; rm -r $d; done"
+    "nuke": "rm -r node_modules; for d in packages/*/node_modules; do echo $d; rm -r $d; done",
+    "format": "lerna run format"
   },
   "resolutions": {
     "@types/webpack": "^4.41.0"

packages/babel-preset-base/@types/babel-helper-plugin-utils.d.ts

@@ -10,11 +10,7 @@ declare module '@babel/helper-plugin-utils' {
 		interface Options {
 			[x: string]: string | Options[] | Options;
 		}
-		type declareHandler = (
-			api: Api,
-			opts: Options,
-			dirname?: string
-		) => any;
+		type declareHandler = (api: Api, opts: Options, dirname?: string) => any;
 		function declare(
 			builder: declareHandler
 		): (api: Api, options: Options, dirname?: string) => any;

packages/babel-preset-base/__mocks__/@babel/helper-plugin-utils.ts

@@ -11,11 +11,9 @@ export interface Api {
 // tslint:disable: no-any
 export type Options = { [x: string]: string | Options[] | Options };
 export type declareHandler = (api: Api, opts: Options, dirname: string) => any;
-export const declare = (builder: declareHandler) => (
-	api: Api,
-	options: Options,
-	dirname: string
-) => {
-	// override api with jest mock
-	return builder(mockedApi as Api, options || {}, dirname);
-};
+export const declare =
+	(builder: declareHandler) =>
+	(api: Api, options: Options, dirname: string) => {
+		// override api with jest mock
+		return builder(mockedApi as Api, options || {}, dirname);
+	};

packages/babel-preset-base/__tests__/preset.spec.ts

@@ -32,8 +32,7 @@ describe('preset in module', () => {
 		const babelConfig = preset();
 		const presetReact = babelConfig.presets.filter(
 			ps =>
-				Array.isArray(ps) &&
-				ps[0] === require.resolve('@babel/preset-react')
+				Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-react')
 		);
 		expect(presetReact).toHaveLength(1);
 	});
@@ -42,8 +41,7 @@ describe('preset in module', () => {
 		const babelConfig = preset({ hasReact: false });
 		const presetReact = babelConfig.presets.filter(
 			ps =>
-				Array.isArray(ps) &&
-				ps[0] === require.resolve('@babel/preset-react')
+				Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-react')
 		);
 		expect(presetReact).toHaveLength(0);
 	});
@@ -88,8 +86,7 @@ describe('preset in module', () => {
 			const babelConfig = preset();
 			const presetEnv = babelConfig.presets.filter(
 				ps =>
-					Array.isArray(ps) &&
-					ps[0] === require.resolve('@babel/preset-env')
+					Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-env')
 			);
 			expect(presetEnv).toHaveLength(1);
 		});
@@ -107,9 +104,7 @@ describe('preset in module', () => {
 			expect(config.presets).toBeInstanceOf(Array);
 			// Now find the one with preset-env
 			const presetEnv = config.presets.find(
-				p =>
-					Array.isArray(p) &&
-					p[0] === require.resolve('@babel/preset-env')
+				p => Array.isArray(p) && p[0] === require.resolve('@babel/preset-env')
 			) as babelPreset;
 			expect(presetEnv).toHaveLength(2);
 			Object.keys(envOptions.presetEnv).forEach(key => {
@@ -134,8 +129,7 @@ describe('preset in module', () => {
 			const babelConfig = preset({ presetReact });
 			const presetReactConfig = babelConfig.presets.find(
 				ps =>
-					Array.isArray(ps) &&
-					ps[0] === require.resolve('@babel/preset-react')
+					Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-react')
 			) as babelPreset;
 			Object.keys(presetReact).forEach(pKey => {
 				if (typeof presetReactConfig[1] === 'object') {
@@ -158,13 +152,10 @@ describe('preset in module', () => {
 				presetReact,
 			}).presets.find(
 				ps =>
-					Array.isArray(ps) &&
-					ps[0] === require.resolve('@babel/preset-react')
+					Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-react')
 			) as babelPreset;
 			if (typeof presetReactConfigWithProduction[1] === 'object') {
-				expect(presetReactConfigWithProduction[1].development).toBe(
-					false
-				);
+				expect(presetReactConfigWithProduction[1].development).toBe(false);
 			} else {
 				throw new Error(
 					'preset does not produce development config for react.'
@@ -176,13 +167,10 @@ describe('preset in module', () => {
 				presetReact,
 			}).presets.find(
 				ps =>
-					Array.isArray(ps) &&
-					ps[0] === require.resolve('@babel/preset-react')
+					Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-react')
 			) as babelPreset;
 			if (typeof presetReactConfigWithDevelopment[1] === 'object') {
-				expect(presetReactConfigWithDevelopment[1].development).toBe(
-					true
-				);
+				expect(presetReactConfigWithDevelopment[1].development).toBe(true);
 			} else {
 				throw new Error(
 					'preset does not produce development config for react.'
@@ -199,13 +187,10 @@ describe('preset in module', () => {
 				presetReact,
 			}).presets.find(
 				ps =>
-					Array.isArray(ps) &&
-					ps[0] === require.resolve('@babel/preset-react')
+					Array.isArray(ps) && ps[0] === require.resolve('@babel/preset-react')
 			) as babelPreset;
 			if (typeof presetReactConfigWithDevelopment[1] === 'object') {
-				expect(presetReactConfigWithDevelopment[1].development).toBe(
-					false
-				);
+				expect(presetReactConfigWithDevelopment[1].development).toBe(false);
 			} else {
 				throw new Error(
 					'preset does not produce development config for react.'

packages/babel-preset-base/package.json

@@ -48,7 +48,8 @@
     "build": "yarn clean && yarn build:types && yarn build:js",
     "lint": "eslint src --ext='.ts,.js'",
     "test": "jest --color",
-    "prepare": "cross-env NODE_ENV=production yarn build"
+    "prepare": "cross-env NODE_ENV=production yarn build",
+    "format": "prettier --write ./src ./__tests__ ./@types ./__mocks__"
   },
   "publishConfig": {
     "access": "public"

packages/cli/package.json

@@ -39,7 +39,8 @@
     "build": "yarn clean && yarn build:types && yarn build:js",
     "build:watch": "yarn clean && yarn build:js --watch",
     "lint": "eslint src --ext='.ts,.js'",
-    "prepare": "cross-env NODE_ENV=production yarn build"
+    "prepare": "cross-env NODE_ENV=production yarn build",
+    "format": "prettier --write ./src"
   },
   "publishConfig": {
     "access": "public"

packages/cli/src/index.ts

@@ -70,7 +70,7 @@ interface Package {
 	scripts?: { [x: string]: string };
 }
 
-// eslint-disable-next-line global-require, @typescript-eslint/no-var-requires
+// eslint-disable-next-line global-require, @typescript-eslint/no-var-requires, import/extensions
 const pkg = require('../package.json') as Package;
 
 program

packages/entrypoint/package.json

@@ -37,7 +37,8 @@
     "build": "yarn clean && yarn build:types && yarn build:js",
     "lint": "eslint src --ext='.ts,.js'",
     "test": "jest --color",
-    "prepare": "cross-env NODE_ENV=production yarn build"
+    "prepare": "cross-env NODE_ENV=production yarn build",
+    "format": "prettier --write ./src ./__tests__"
   },
   "publishConfig": {
     "access": "public"

packages/eslint-config/CHANGELOG.md

@@ -5,164 +5,106 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
 
 # [6.3.0](https://github.com/swashata/wp-webpack-script/compare/v6.2.0...v6.3.0) (2021-05-26)
 
-
 ### Bug Fixes
 
-* babel plugin not being configured properly for ts ([2b8b2df](https://github.com/swashata/wp-webpack-script/commit/2b8b2dfbc35b9b31f10ef4851add069d611ca1d7))
-
-
-
-
+- babel plugin not being configured properly for ts ([2b8b2df](https://github.com/swashata/wp-webpack-script/commit/2b8b2dfbc35b9b31f10ef4851add069d611ca1d7))
 
 ## [6.0.1](https://github.com/swashata/wp-webpack-script/compare/v6.0.0...v6.0.1) (2021-04-27)
 
-
 ### Bug Fixes
 
-* eslint typescript issue with no-use-before-define ([bce027a](https://github.com/swashata/wp-webpack-script/commit/bce027ad2f3d5571eda2e9d180c488b0955e6a8b)), closes [typescript-eslint/typescript-eslint#2502](https://github.com/typescript-eslint/typescript-eslint/issues/2502)
-
-
-
-
+- eslint typescript issue with no-use-before-define ([bce027a](https://github.com/swashata/wp-webpack-script/commit/bce027ad2f3d5571eda2e9d180c488b0955e6a8b)), closes [typescript-eslint/typescript-eslint#2502](https://github.com/typescript-eslint/typescript-eslint/issues/2502)
 
 # [6.0.0](https://github.com/swashata/wp-webpack-script/compare/v5.0.0...v6.0.0) (2021-04-26)
 
-
 ### Bug Fixes
 
-* **deps:** update dependency eslint-import-resolver-typescript to v2.2.1 ([144d55f](https://github.com/swashata/wp-webpack-script/commit/144d55f2f5a01e9467383b3797a2a886f1f1c992))
-* **deps:** update dependency eslint-import-resolver-typescript to v2.3.0 ([e9d4c04](https://github.com/swashata/wp-webpack-script/commit/e9d4c04a758f0996b7627d98992cc5e6731a293b))
-* **deps:** update typescript-eslint monorepo to v3.10.0 ([7401373](https://github.com/swashata/wp-webpack-script/commit/74013737c6d4d3fce44e9d055a573f998ee5687f))
-* **deps:** update typescript-eslint monorepo to v3.10.1 ([637aec0](https://github.com/swashata/wp-webpack-script/commit/637aec0ffb98a0bb4cb3945a8909805f0afeab11))
-* **deps:** update typescript-eslint monorepo to v3.9.0 ([e5ab0c7](https://github.com/swashata/wp-webpack-script/commit/e5ab0c7180e72b7c960a5af1a04ca0bd96f60473))
-* **deps:** update typescript-eslint monorepo to v3.9.1 ([ee659ec](https://github.com/swashata/wp-webpack-script/commit/ee659ecca4f846c3e5215eb2ee29ab876a435335))
-
+- **deps:** update dependency eslint-import-resolver-typescript to v2.2.1 ([144d55f](https://github.com/swashata/wp-webpack-script/commit/144d55f2f5a01e9467383b3797a2a886f1f1c992))
+- **deps:** update dependency eslint-import-resolver-typescript to v2.3.0 ([e9d4c04](https://github.com/swashata/wp-webpack-script/commit/e9d4c04a758f0996b7627d98992cc5e6731a293b))
+- **deps:** update typescript-eslint monorepo to v3.10.0 ([7401373](https://github.com/swashata/wp-webpack-script/commit/74013737c6d4d3fce44e9d055a573f998ee5687f))
+- **deps:** update typescript-eslint monorepo to v3.10.1 ([637aec0](https://github.com/swashata/wp-webpack-script/commit/637aec0ffb98a0bb4cb3945a8909805f0afeab11))
+- **deps:** update typescript-eslint monorepo to v3.9.0 ([e5ab0c7](https://github.com/swashata/wp-webpack-script/commit/e5ab0c7180e72b7c960a5af1a04ca0bd96f60473))
+- **deps:** update typescript-eslint monorepo to v3.9.1 ([ee659ec](https://github.com/swashata/wp-webpack-script/commit/ee659ecca4f846c3e5215eb2ee29ab876a435335))
 
 ### Features
 
-* upgrade all eslint related dependencies ([42cd20b](https://github.com/swashata/wp-webpack-script/commit/42cd20ba62c8cef69909c08c648180c9083e1f1d))
-
-
-
-
+- upgrade all eslint related dependencies ([42cd20b](https://github.com/swashata/wp-webpack-script/commit/42cd20ba62c8cef69909c08c648180c9083e1f1d))
 
 # [5.0.0](https://github.com/swashata/wp-webpack-script/compare/v4.4.1...v5.0.0) (2020-08-07)
 
-
 ### Features
 
-* add react refresh support ([1f4cb57](https://github.com/swashata/wp-webpack-script/commit/1f4cb579a0191dbcdc5a277d41944ad5acdf520f))
-* make fork-ts plugin 5 compatible and remove react-dev-utils ([a6f414d](https://github.com/swashata/wp-webpack-script/commit/a6f414d644dc9552942b9b23172ff35c49b5ea78))
-
-
-
-
+- add react refresh support ([1f4cb57](https://github.com/swashata/wp-webpack-script/commit/1f4cb579a0191dbcdc5a277d41944ad5acdf520f))
+- make fork-ts plugin 5 compatible and remove react-dev-utils ([a6f414d](https://github.com/swashata/wp-webpack-script/commit/a6f414d644dc9552942b9b23172ff35c49b5ea78))
 
 ## [4.4.1](https://github.com/swashata/wp-webpack-script/compare/v4.4.0...v4.4.1) (2020-03-21)
 
 **Note:** Version bump only for package @wpackio/eslint-config
 
-
-
-
-
 # [4.4.0](https://github.com/swashata/wp-webpack-script/compare/v4.3.0...v4.4.0) (2020-03-17)
 
-
 ### Bug Fixes
 
-* **deps:** update typescript-eslint monorepo to v2.14.0 ([dd84488](https://github.com/swashata/wp-webpack-script/commit/dd844889b6862d7693ecf92778faa5724e865553))
-* **deps:** update typescript-eslint monorepo to v2.15.0 ([395edd1](https://github.com/swashata/wp-webpack-script/commit/395edd16fab781d4415e226829c4e071c4ed6d32))
-* **deps:** update typescript-eslint monorepo to v2.16.0 ([0b22306](https://github.com/swashata/wp-webpack-script/commit/0b22306b516eb707126def8fa7a658c4d7531ef7))
-* **deps:** update typescript-eslint monorepo to v2.17.0 ([8a73f52](https://github.com/swashata/wp-webpack-script/commit/8a73f52db06334b81c2a430c0c76721f3d7e056d))
-* **deps:** update typescript-eslint monorepo to v2.18.0 ([9b55d96](https://github.com/swashata/wp-webpack-script/commit/9b55d96b330d051b2cc82bdba25443a3f23811e5))
-* **deps:** update typescript-eslint monorepo to v2.19.0 ([b820955](https://github.com/swashata/wp-webpack-script/commit/b820955cc688b2963f08a3170e5596418de976eb))
-* **deps:** update typescript-eslint monorepo to v2.19.2 ([ca47d4d](https://github.com/swashata/wp-webpack-script/commit/ca47d4d83ca583198702debf072120609d9801f6))
-* **deps:** update typescript-eslint monorepo to v2.20.0 ([33f3476](https://github.com/swashata/wp-webpack-script/commit/33f347631be6794d511b0d6b385e567cd53fff3f))
-* **deps:** update typescript-eslint monorepo to v2.21.0 ([7089dc0](https://github.com/swashata/wp-webpack-script/commit/7089dc0d54d406292d48297e7578dfb62588fbcf))
-* **deps:** update typescript-eslint monorepo to v2.22.0 ([ab188ca](https://github.com/swashata/wp-webpack-script/commit/ab188caa450dd08c7139b2a6659b1d5080f8015a))
-* **deps:** update typescript-eslint monorepo to v2.23.0 ([39c1bd2](https://github.com/swashata/wp-webpack-script/commit/39c1bd22ccd5a7b09b172648d1195619ca9d7bdd))
-* **deps:** update typescript-eslint monorepo to v2.24.0 ([be3fabf](https://github.com/swashata/wp-webpack-script/commit/be3fabf08fb6b23e5fa398625d2964732ecd17b2))
-
-
-
-
+- **deps:** update typescript-eslint monorepo to v2.14.0 ([dd84488](https://github.com/swashata/wp-webpack-script/commit/dd844889b6862d7693ecf92778faa5724e865553))
+- **deps:** update typescript-eslint monorepo to v2.15.0 ([395edd1](https://github.com/swashata/wp-webpack-script/commit/395edd16fab781d4415e226829c4e071c4ed6d32))
+- **deps:** update typescript-eslint monorepo to v2.16.0 ([0b22306](https://github.com/swashata/wp-webpack-script/commit/0b22306b516eb707126def8fa7a658c4d7531ef7))
+- **deps:** update typescript-eslint monorepo to v2.17.0 ([8a73f52](https://github.com/swashata/wp-webpack-script/commit/8a73f52db06334b81c2a430c0c76721f3d7e056d))
+- **deps:** update typescript-eslint monorepo to v2.18.0 ([9b55d96](https://github.com/swashata/wp-webpack-script/commit/9b55d96b330d051b2cc82bdba25443a3f23811e5))
+- **deps:** update typescript-eslint monorepo to v2.19.0 ([b820955](https://github.com/swashata/wp-webpack-script/commit/b820955cc688b2963f08a3170e5596418de976eb))
+- **deps:** update typescript-eslint monorepo to v2.19.2 ([ca47d4d](https://github.com/swashata/wp-webpack-script/commit/ca47d4d83ca583198702debf072120609d9801f6))
+- **deps:** update typescript-eslint monorepo to v2.20.0 ([33f3476](https://github.com/swashata/wp-webpack-script/commit/33f347631be6794d511b0d6b385e567cd53fff3f))
+- **deps:** update typescript-eslint monorepo to v2.21.0 ([7089dc0](https://github.com/swashata/wp-webpack-script/commit/7089dc0d54d406292d48297e7578dfb62588fbcf))
+- **deps:** update typescript-eslint monorepo to v2.22.0 ([ab188ca](https://github.com/swashata/wp-webpack-script/commit/ab188caa450dd08c7139b2a6659b1d5080f8015a))
+- **deps:** update typescript-eslint monorepo to v2.23.0 ([39c1bd2](https://github.com/swashata/wp-webpack-script/commit/39c1bd22ccd5a7b09b172648d1195619ca9d7bdd))
+- **deps:** update typescript-eslint monorepo to v2.24.0 ([be3fabf](https://github.com/swashata/wp-webpack-script/commit/be3fabf08fb6b23e5fa398625d2964732ecd17b2))
 
 # [4.3.0](https://github.com/swashata/wp-webpack-script/compare/v4.2.0...v4.3.0) (2019-12-26)
 
-
 ### Bug Fixes
 
-* **deps:** update typescript-eslint monorepo to v2.10.0 ([ca04d6e](https://github.com/swashata/wp-webpack-script/commit/ca04d6e))
-* **deps:** update typescript-eslint monorepo to v2.11.0 ([7279e02](https://github.com/swashata/wp-webpack-script/commit/7279e02))
-* **deps:** update typescript-eslint monorepo to v2.12.0 ([a97f702](https://github.com/swashata/wp-webpack-script/commit/a97f702))
-* **deps:** update typescript-eslint monorepo to v2.13.0 ([d9b9e58](https://github.com/swashata/wp-webpack-script/commit/d9b9e58))
-* **deps:** update typescript-eslint monorepo to v2.7.0 ([a855ea8](https://github.com/swashata/wp-webpack-script/commit/a855ea8))
-* **deps:** update typescript-eslint monorepo to v2.8.0 ([777747b](https://github.com/swashata/wp-webpack-script/commit/777747b))
-* **deps:** update typescript-eslint monorepo to v2.9.0 ([e76beed](https://github.com/swashata/wp-webpack-script/commit/e76beed))
-
-
-
-
+- **deps:** update typescript-eslint monorepo to v2.10.0 ([ca04d6e](https://github.com/swashata/wp-webpack-script/commit/ca04d6e))
+- **deps:** update typescript-eslint monorepo to v2.11.0 ([7279e02](https://github.com/swashata/wp-webpack-script/commit/7279e02))
+- **deps:** update typescript-eslint monorepo to v2.12.0 ([a97f702](https://github.com/swashata/wp-webpack-script/commit/a97f702))
+- **deps:** update typescript-eslint monorepo to v2.13.0 ([d9b9e58](https://github.com/swashata/wp-webpack-script/commit/d9b9e58))
+- **deps:** update typescript-eslint monorepo to v2.7.0 ([a855ea8](https://github.com/swashata/wp-webpack-script/commit/a855ea8))
+- **deps:** update typescript-eslint monorepo to v2.8.0 ([777747b](https://github.com/swashata/wp-webpack-script/commit/777747b))
+- **deps:** update typescript-eslint monorepo to v2.9.0 ([e76beed](https://github.com/swashata/wp-webpack-script/commit/e76beed))
 
 # [4.2.0](https://github.com/swashata/wp-webpack-script/compare/v4.1.0...v4.2.0) (2019-10-29)
 
-
 ### Bug Fixes
 
-* **deps:** update typescript-eslint monorepo to v2.6.0 ([9ddf114](https://github.com/swashata/wp-webpack-script/commit/9ddf114))
-
-
-
-
+- **deps:** update typescript-eslint monorepo to v2.6.0 ([9ddf114](https://github.com/swashata/wp-webpack-script/commit/9ddf114))
 
 # [4.0.0](https://github.com/swashata/wp-webpack-script/compare/v3.5.0...v4.0.0) (2019-10-28)
 
-
 ### Bug Fixes
 
-* issue with eslint, updated deps and typescript ([2625e7d](https://github.com/swashata/wp-webpack-script/commit/2625e7d))
-
+- issue with eslint, updated deps and typescript ([2625e7d](https://github.com/swashata/wp-webpack-script/commit/2625e7d))
 
 ### Features
 
-* update eslint-config for eslint 6 ([46a3554](https://github.com/swashata/wp-webpack-script/commit/46a3554))
-
-
-
-
+- update eslint-config for eslint 6 ([46a3554](https://github.com/swashata/wp-webpack-script/commit/46a3554))
 
 # [3.5.0](https://github.com/swashata/wp-webpack-script/compare/v3.4.0...v3.5.0) (2019-05-04)
 
-
 ### Bug Fixes
 
-* **deps:** update dependencies ([01711b0](https://github.com/swashata/wp-webpack-script/commit/01711b0))
-
-
-
-
+- **deps:** update dependencies ([01711b0](https://github.com/swashata/wp-webpack-script/commit/01711b0))
 
 # [3.2.0](https://github.com/swashata/wp-webpack-script/compare/v3.1.0...v3.2.0) (2019-04-28)
 
-
 ### Bug Fixes
 
-* **deps:** update dependencies ([1146e63](https://github.com/swashata/wp-webpack-script/commit/1146e63))
-* **deps:** update typescript-eslint monorepo to v1.7.0 ([56967d9](https://github.com/swashata/wp-webpack-script/commit/56967d9))
-
-
-
-
+- **deps:** update dependencies ([1146e63](https://github.com/swashata/wp-webpack-script/commit/1146e63))
+- **deps:** update typescript-eslint monorepo to v1.7.0 ([56967d9](https://github.com/swashata/wp-webpack-script/commit/56967d9))
 
 # [3.0.0](https://github.com/swashata/wp-webpack-script/compare/v2.13.0...v3.0.0) (2019-04-16)
 
-
 ### Bug Fixes
 
-* **eslint-config:** issues within ts and js config ([33c0661](https://github.com/swashata/wp-webpack-script/commit/33c0661))
-
+- **eslint-config:** issues within ts and js config ([33c0661](https://github.com/swashata/wp-webpack-script/commit/33c0661))
 
 ### Features
 
-* add sharable eslint config ([9eb1e2c](https://github.com/swashata/wp-webpack-script/commit/9eb1e2c)), closes [#434](https://github.com/swashata/wp-webpack-script/issues/434)
+- add sharable eslint config ([9eb1e2c](https://github.com/swashata/wp-webpack-script/commit/9eb1e2c)), closes [#434](https://github.com/swashata/wp-webpack-script/issues/434)