PR feedback

Author: qmfrederik

CMakeLists.txt

@@ -74,6 +74,26 @@ int main(int argc, char *argv[]) {
   if(HAVE_MKSTEMP)
     add_compile_definitions(HAVE_MKSTEMP)
   endif()
+
+  check_c_source_compiles([=[
+#include <sys/types.h>
+int main(int argc, char *argv[]) {
+  mode_t mode;
+}
+]=] HAVE_MODE_T)
+  if(HAVE_MODE_T)
+    add_compile_definitions(HAVE_MODE_T)
+  endif()
+
+  check_c_source_compiles([=[
+#include <sys/types.h>
+int main(int argc, char *argv[]) {
+  pid_t mode;
+}
+]=] HAVE_PID_T)
+  if(HAVE_PID_T)
+    add_compile_definitions(HAVE_PID_T)
+  endif()
 endif()
 
 set(CMAKE_C_STANDARD 11)

cmake/modules/DispatchCompilerWarnings.cmake

@@ -1,7 +1,9 @@
 
-if("${CMAKE_C_SIMULATE_ID}" STREQUAL "MSVC" OR MINGW)
+if("${CMAKE_C_SIMULATE_ID}" STREQUAL "MSVC")
   # TODO: someone needs to provide the msvc equivalent warning flags
-  # -fms-extensions will enable __popcnt64
+elseif(WIN32)
+  # Tareting Windows but using a non-MSVC compiler.  Set -fms-extensions
+  # so that we can use __popcnt64
   add_compile_options($<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:-fms-extensions>)
 else()
   add_compile_options($<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:-Werror>)

os/generic_win_base.h

@@ -24,8 +24,7 @@
 // Unices provide `howmany` via sys/param.h
 #define howmany(x, y)  (((x) + ((y) - 1)) / (y))
 
-#ifndef _MODE_T_
-#define	_MODE_T_
+#ifndef HAVE_MODE_T
 typedef int mode_t;
 #endif
 typedef void pthread_attr_t;

tests/generic_win_port.h

@@ -7,7 +7,7 @@
 #include <Windows.h>
 
 typedef int kern_return_t;
-#ifndef _PID_T_
+#ifndef HAVE_PID_T
 typedef int pid_t;
 #endif