SILCombine: don't remove dead Array adoptStorage call

If followed by a dead infinite loop, the array initialization might have beed removed.
Therefore when inserting a compensating destroy of the array buffer can lead to a crash.

#85851
rdar://165876726

Author: eeckstein

lib/SILOptimizer/SILCombiner/SILCombinerApplyVisitors.cpp

@@ -1561,14 +1561,6 @@ SILInstruction *SILCombiner::legacyVisitApplyInst(ApplyInst *AI) {
   }
 
   if (SF) {
-    if (SF->hasSemanticsAttr(semantics::ARRAY_UNINITIALIZED)) {
-      UserListTy Users;
-      // If the uninitialized array is only written into then it can be removed.
-      if (recursivelyCollectARCUsers(Users, AI)) {
-        if (eraseApply(AI, Users))
-          return nullptr;
-      }
-    }
     if (SF->hasSemanticsAttr(semantics::ARRAY_GET_CONTIGUOUSARRAYSTORAGETYPE)) {
       auto silTy = AI->getType();
       auto storageTy = AI->getType().getASTType();

test/SILOptimizer/sil_combine_apply.sil

@@ -1037,3 +1037,22 @@ bb3:
   %rv = tuple()
   return %rv : $()
 }
+
+
+sil [_semantics "array.uninitialized"] [ossa] @adoptStorage : $@convention(thin) (@owned _ContiguousArrayStorage<Any>, Int) -> (@owned Array<Any>, UnsafeMutablePointer<Any>)
+
+// CHECK-LABEL: sil [ossa] @dont_remove_dead_adopt_storage :
+// CHECK-NOT:     destroy_value
+// CHECK-LABEL: } // end sil function 'dont_remove_dead_adopt_storage'
+sil [ossa] @dont_remove_dead_adopt_storage : $@convention(thin) (Int) -> () {
+bb0(%0 : $Int):
+  %1 = integer_literal $Builtin.Word, 1
+  %2 = alloc_ref [tail_elems $Any * %1] $_ContiguousArrayStorage<Any>
+  %3 = function_ref @adoptStorage : $@convention(thin) (@owned _ContiguousArrayStorage<Any>, Int) -> (@owned Array<Any>, UnsafeMutablePointer<Any>)
+  %4 = apply %3(%2, %0) : $@convention(thin) (@owned _ContiguousArrayStorage<Any>, Int) -> (@owned Array<Any>, UnsafeMutablePointer<Any>)
+  // Array buffer is not initialized due to dead-end loop -> will lead to crash if buffer is destroyed here
+  br bb1
+bb1:
+  br bb1
+}
+