fix: if certificate obtain got failed log it and mark as failed (#1114) (#1115)

* fix: if certificate obtain got failed log it and mark as failed

* fix: log more info about ssl cert issue failure

(cherry picked from commit 527b940)

Co-authored-by: Tanmoy Sarkar <57363826+tanmoysrt@users.noreply.github.com>

Author: mergify[bot]

ssl_manager/generator.go

@@ -26,11 +26,11 @@ func (s Manager) ObtainCertificate(domain string, privateKeyStr string) (string,
 	// Parse the DER-encoded key data
 	privateKey, err := x509.ParsePKCS1PrivateKey(block.Bytes)
 	if err != nil {
-		return "", errors.New("unable to parse private key for domain")
+		return "", errors.New("unable to parse private key for domain > " + err.Error())
 	}
 	certs, err := s.client.ObtainCertificate(s.ctx, s.account, privateKey, []string{domain})
 	if err != nil {
-		return "", errors.New("unable to obtain certificate")
+		return "", errors.New("unable to obtain certificate > " + err.Error())
 	}
 	// Get the certificate
 	certificate := certs[0]

swiftwave_service/worker/process_ssl_request.go

@@ -61,7 +61,8 @@ func (m Manager) SSLGenerate(request SSLGenerateRequest, ctx context.Context, _
 	fullChain, err := m.ServiceManager.SslManager.ObtainCertificate(domain.Name, domain.SSLPrivateKey)
 	if err != nil {
 		// don' requeue, if anything happen user can anytime re-request for certificate
-		logger.CronJobLoggerError.Println("Failed to obtain certificate", err.Error(), "\nWill retry later")
+		logger.CronJobLoggerError.Println("Failed to obtain certificate", err.Error())
+		_ = domain.UpdateSSLStatus(ctx, dbWithoutTx, core.DomainSSLStatusFailed)
 		return nil
 	}
 	// store certificate