Commit 0064420
committed
minor #2503 [CI] Fix and display changed dist files in the CI (Kocal)
This PR was merged into the 2.x branch.
Discussion
----------
[CI] Fix and display changed dist files in the CI
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- For new features, provide some code snippets to help understand usage.
- Features and deprecations must be submitted against branch main.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
- Never break backward compatibility (see https://symfony.com/bc).
-->
When working on https://github.com/symfony/stimulus-bridge, I've added a new job CI that shows when dist files are up-to-date or need to be build.
No surprise, I re-used what was on UX, but I found it was not correct: https://github.com/symfony/stimulus-bridge/actions/runs/12743300005/job/35512968204?pr=96
<img width="993" alt="image" src="https://github.com/user-attachments/assets/564c5a93-3aed-4fca-abee-32fd01ec72d2" />
The command that checks if files are up-to-date fails, to me it is not working as expected.
Instead, I've simplified things and added a `git diff` to display the changes:
<img width="1017" alt="image" src="https://github.com/user-attachments/assets/666112e3-5247-4331-8c8a-edec57b3a9aa" />
WDYT?
Commits
-------
59a6efc [CI] Fix and display changed dist files in the CI1 file changed
+9
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 50 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
| 51 | + | |
61 | 52 | | |
62 | | - | |
63 | | - | |
64 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
65 | 61 | | |
66 | 62 | | |
67 | 63 | | |
| |||
0 commit comments