Skip to content

Commit d08dfa5

Browse files
author
iru
authored
docs: clarify acceptance test env (#240)
1 parent af49cf9 commit d08dfa5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ If you want to execute the **acceptance tests**, you can run `make testacc`.
6464
- Follow [Terraform acceptance test guideliness](https://www.terraform.io/plugin/sdkv2/testing/acceptance-tests)
6565
- Please note that you need a token for Sysdig Monitor and another one for Sysdig Secure, and since the **acceptance tests create real infrastructure**
6666
you should execute them in an environment where you can remove the resources easily.
67-
- Acceptance tests are launched in Sysdig production environment
67+
- Acceptance tests are launched in [Sysdig production `+kubelab` test environment](https://github.com/sysdiglabs/terraform-provider-sysdig/blob/master/.github/workflows/ci-pull-request.yml#L82-L83)
6868

6969
```sh
7070
$ make testacc
@@ -121,6 +121,7 @@ Interesting resources
121121
- Defined in [`/.pre-commit-config.yaml`](https://github.com/sysdiglabs/terraform-provider-sysdig/blob/master/.pre-commit-config.yaml)
122122
- You can work on this before even pushing to remote, using [**pre-commit**](https://pre-commit.com) plugin
123123

124+
* for the PR title use [conventional commit format](https://www.conventionalcommits.org/en/v1.0.0/) so when the branch is squashed to main branch it follows a convention
124125
* for Acceptance Tests `testacc` some credentials are required, check [`/.envrc.template`](https://github.com/sysdiglabs/terraform-provider-sysdig/blob/master/.envrc.template)
125126

126127

0 commit comments

Comments
 (0)