Merge pull request #24 from tattersoftware/session-length

Session ID Length

Author: MGatner

src/Database/Migrations/20220712095055_alter_session_length.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Tatter\Visits\Database\Migrations;
+
+use CodeIgniter\Database\Migration;
+
+class AlterSessionLength extends Migration
+{
+    /**
+     * @return void
+     */
+    public function up()
+    {
+        $this->forge->modifyColumn('visits', [
+            'session_id' => ['type' => 'varchar', 'constraint' => 127],
+        ]);
+    }
+
+    /**
+     * @return void
+     */
+    public function down()
+    {
+        $this->forge->modifyColumn('visits', [
+            'session_id' => ['type' => 'varchar', 'constraint' => 32],
+        ]);
+    }
+}

src/Models/VisitModel.php

@@ -30,8 +30,9 @@ class VisitModel extends Model
         'fragment',
     ];
     protected $validationRules = [
-        'host' => 'required',
-        'path' => 'required',
+        'host'       => 'required',
+        'path'       => 'required',
+        'session_id' => 'permit_empty|max_length[127]',
     ];
 
     /**

tests/ModelTest.php

@@ -129,4 +129,18 @@ public function testMakeFromRequestConvertsIp(): void
 
         unset($_SERVER['REMOTE_ADDR']);
     }
+
+    /**
+     * @see https://github.com/tattersoftware/codeigniter4-visits/issues/23
+     */
+    public function testAllowsLongSessionIds(): void
+    {
+        $expected = 'Who shall call them from the grey twilight the forgotten people The heir of him to whom the oath they swore';
+        fake(VisitModel::class, ['session_id' => $expected]);
+
+        $result = $this->model->first();
+
+        $this->assertInstanceOf(Visit::class, $result);
+        $this->assertSame($expected, $result->session_id);
+    }
 }