🔥 remove redundant tests for MySQL to SQLite view conversion

Author: techouse

tests/unit/test_views_sqlglot.py

@@ -6,87 +6,6 @@
 from mysql_to_sqlite3.transporter import MySQLtoSQLite
 
 
-class TestViewsSqlglot:
-    def test_mysql_viewdef_to_sqlite_strips_schema_and_transpiles(self) -> None:
-        mysql_select = "SELECT `u`.`id`, `u`.`name` FROM `db`.`users` AS `u` WHERE `u`.`id` > 1"
-        # Use an instance to ensure access to _mysql_database for stripping
-        with patch.object(MySQLtoSQLite, "__init__", return_value=None):
-            inst = MySQLtoSQLite()  # type: ignore[call-arg]
-        inst._mysql_database = "db"  # type: ignore[attr-defined]
-        sql = inst._mysql_viewdef_to_sqlite(
-            view_select_sql=mysql_select,
-            view_name="v_users",
-        )
-        assert sql.startswith('CREATE VIEW IF NOT EXISTS "v_users" AS')
-        # Ensure schema qualifier was removed
-        assert '"db".' not in sql
-        assert "`db`." not in sql
-        # Ensure it targets sqlite dialect (identifiers quoted with ")
-        assert 'FROM "users"' in sql
-        # Ends with single semicolon
-        assert re.search(r";\s*$", sql) is not None
-
-    def test_mysql_viewdef_to_sqlite_parse_fallback(self, monkeypatch: pytest.MonkeyPatch) -> None:
-        # Force parse_one to raise so we hit the fallback path
-        from sqlglot.errors import ParseError
-
-        def boom(*args, **kwargs):
-            raise ParseError("boom")
-
-        monkeypatch.setattr("mysql_to_sqlite3.transporter.parse_one", boom)
-
-        sql_in = "SELECT 1"
-        out = MySQLtoSQLite._mysql_viewdef_to_sqlite(
-            view_select_sql=sql_in,
-            view_name="v1",
-            schema_name="db",
-        )
-        assert out.startswith('CREATE VIEW IF NOT EXISTS "v1" AS')
-        assert "SELECT 1" in out
-        assert out.strip().endswith(";")
-
-    def test_mysql_viewdef_to_sqlite_parse_fallback_strips_schema(self, monkeypatch: pytest.MonkeyPatch) -> None:
-        # Force parse_one to raise so we exercise the fallback path with schema qualifiers
-        from sqlglot.errors import ParseError
-
-        def boom(*args, **kwargs):
-            raise ParseError("boom")
-
-        monkeypatch.setattr("mysql_to_sqlite3.transporter.parse_one", boom)
-
-        mysql_select = "SELECT `u`.`id` FROM `db`.`users` AS `u` WHERE `u`.`id` > 1"
-        out = MySQLtoSQLite._mysql_viewdef_to_sqlite(
-            view_select_sql=mysql_select,
-            view_name="v_users",
-            schema_name="db",
-        )
-        # Should not contain schema qualifier anymore
-        assert "`db`." not in out and '"db".' not in out and " db." not in out
-        # Should still reference the table name
-        assert "FROM `users`" in out or 'FROM "users"' in out or "FROM users" in out
-        assert out.strip().endswith(";")
-
-    def test_mysql_viewdef_to_sqlite_keep_schema_true_preserves_qualifiers(self) -> None:
-        mysql_select = "SELECT `u`.`id` FROM `db`.`users` AS `u`"
-        sql = MySQLtoSQLite._mysql_viewdef_to_sqlite(
-            view_select_sql=mysql_select,
-            view_name="v_users",
-            schema_name="db",
-            keep_schema=True,
-        )
-        # Should not strip the schema when keep_schema=True
-        assert "`db`." in sql or '"db".' in sql
-        assert sql.strip().endswith(";")
-
-
-import re
-from unittest.mock import patch
-
-import pytest
-
-from mysql_to_sqlite3.transporter import MySQLtoSQLite
-
-
 class TestViewsSqlglot:
     def test_mysql_viewdef_to_sqlite_strips_schema_and_transpiles(self) -> None:
         mysql_select = "SELECT `u`.`id`, `u`.`name` FROM `db`.`users` AS `u` WHERE `u`.`id` > 1"