🐛 refine exception handling in transporter for unexpected sqlglot failures

techouse · techouse · commit 1fca33ac0a58 · 2025-10-19T15:25:43.000+01:00
diff --git a/src/mysql_to_sqlite3/transporter.py b/src/mysql_to_sqlite3/transporter.py
@@ -318,7 +318,7 @@ def _transpile_mysql_expr_to_sqlite(cls, expr_sql: str) -> t.Optional[str]:
             return tree.sql(dialect="sqlite")
         except (ParseError, ValueError):
             return None
-        except Exception:  # pragma: no cover
+        except (AttributeError, TypeError):  # pragma: no cover - unexpected sqlglot failure
             logging.getLogger(cls.__name__ if hasattr(cls, "__name__") else "MySQLtoSQLite").debug(
                 "sqlglot failed to transpile expr: %r", expr_sql
             )

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ def _transpile_mysql_expr_to_sqlite(cls, expr_sql: str) -> t.Optional[str]:`
`318`	`318`	`return tree.sql(dialect="sqlite")`
`319`	`319`	`except (ParseError, ValueError):`
`320`	`320`	`return None`
`321`		`- except Exception: # pragma: no cover`
	`321`	`+ except (AttributeError, TypeError): # pragma: no cover - unexpected sqlglot failure`
`322`	`322`	`logging.getLogger(cls.__name__ if hasattr(cls, "__name__") else "MySQLtoSQLite").debug(`
`323`	`323`	`"sqlglot failed to transpile expr: %r", expr_sql`
`324`	`324`	`)`