From 824801cfcd2718d93d65b7bc48202db644fd7ba3 Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 8 May 2025 18:05:59 +0100 Subject: [PATCH 1/5] ci(nodejs): add node 24 to test matrix --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index d012346e..e70fdaf7 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -122,7 +122,7 @@ jobs: strategy: matrix: os: [windows-2019, windows-2022] - node: [18.x, 20.x, 22.x] + node: [18.x, 20.x, 22.x, 24.x] sqlserver: [2008, 2012, 2014, 2016, 2017, 2019, 2022] # These sqlserver versions don't work on windows-2022 (at the moment) exclude: From 3badd524c6e490ca81c9fc00ece9aef99c37445b Mon Sep 17 00:00:00 2001 From: Dan Hensby Date: Tue, 20 May 2025 10:58:18 +0100 Subject: [PATCH 2/5] ci: remove sql server 2017 runs from linux test suite The 2017 test suite only runs on Ubuntu 20.04, but this runner has been removed by GitHub now so the suite cannot be run in GH workflows. --- .github/workflows/nodejs.yml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index e70fdaf7..16c28d2e 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -67,16 +67,9 @@ jobs: MSSQL_PASSWORD: 'yourStrong(!)Password' strategy: matrix: - os: [ubuntu-20.04, ubuntu-24.04] + os: [ubuntu-24.04] node: [18.x, 20.x, 22.x] - sqlserver: [2017, 2019, 2022] - exclude: - - os: ubuntu-24.04 - sqlserver: 2017 - - os: ubuntu-20.04 - sqlserver: 2019 - - os: ubuntu-20.04 - sqlserver: 2022 + sqlserver: [2019, 2022] steps: - name: Checkout code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 From ca5f1944f746ade2eab161e8ec97f4aa21f988a1 Mon Sep 17 00:00:00 2001 From: Dan Hensby Date: Tue, 20 May 2025 11:07:11 +0100 Subject: [PATCH 3/5] ci: add node 22.x to linux runs --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 16c28d2e..b4431192 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -68,7 +68,7 @@ jobs: strategy: matrix: os: [ubuntu-24.04] - node: [18.x, 20.x, 22.x] + node: [18.x, 20.x, 22.x, 24.x] sqlserver: [2019, 2022] steps: - name: Checkout code From 119a1879e15c14346d56897dfd33125f0409123b Mon Sep 17 00:00:00 2001 From: Dan Hensby Date: Tue, 20 May 2025 11:07:48 +0100 Subject: [PATCH 4/5] ci: bump base runs from ubuntu-22 to ubuntu-24 --- .github/workflows/nodejs.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index b4431192..948d1ac8 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -12,7 +12,7 @@ permissions: jobs: commitlint: name: Lint commits - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Checkout code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -34,7 +34,7 @@ jobs: run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose codelint: name: Lint code - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Checkout code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -162,7 +162,7 @@ jobs: name: Release concurrency: release if: ${{ github.repository_owner == 'tediousjs' && github.event_name == 'push' && github.actor != 'dependabot[bot]' }} - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 needs: - commitlint - codelint From 9ce72a253cd3f687de9b40842ef9ac85dbd151f2 Mon Sep 17 00:00:00 2001 From: Dan Hensby Date: Tue, 20 May 2025 11:54:43 +0100 Subject: [PATCH 5/5] ci: msnodesqlv8 tests on node.js >=22 --- .github/workflows/nodejs.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 948d1ac8..b87eb574 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -153,10 +153,16 @@ jobs: - name: Run cli tests run: npm run test-cli - name: Install msnodesqlv8 - if: ${{ matrix.node != '22.x' }} + if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }} run: npm install --no-save msnodesqlv8@^2 - name: Run msnodesqlv8 tests - if: ${{ matrix.node != '22.x' }} + if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }} + run: npm run test-msnodesqlv8 + - name: Install msnodesqlv8 + if: ${{ matrix.node == '22.x' || matrix.node == '24.x' }} + run: npm install --no-save msnodesqlv8@^4 + - name: Run msnodesqlv8 tests + if: ${{ matrix.node == '22.x' && matrix.node == '24.x' }} run: npm run test-msnodesqlv8 release: name: Release