-
Notifications
You must be signed in to change notification settings - Fork 109
Implementation of the ability to send js challenge according with custom rules. #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
biathlon3
wants to merge
2
commits into
master
Choose a base branch
from
ag_2104-implement-ability-to-send-js-challenge-according-custom-rules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implementation of the ability to send js challenge according with custom rules. #2131
biathlon3
wants to merge
2
commits into
master
from
ag_2104-implement-ability-to-send-js-challenge-according-custom-rules
+31
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30ffc30 to
14766c3
Compare
enuribekov-tempesta
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
acbebd6 to
f920564
Compare
EvgeniiMekhanik
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rework. We also need changes in etc/tempesta_fw.conf - descriptions and examples
f920564 to
81e8d73
Compare
Add new HTTPtables action - `jsch` it allows to mark
a request as challengeable by JS challenge. If
js challengeable is not configured for virtual host
where request was routed, challenge will not be sent.
Example:
Make requests with "accept: text/html" are challengeable.
```
http_chain {
hdr "accept" == 'text/html' -> jsch;
}
```
Remove flag TFW_HTTP_B_ACCEPT_HTML, it being used only by js challenge code. Remove hpack state of accept header used only for setting TFW_HTTP_B_ACCEPT_HTML when header is in dynamic table.
81e8d73 to
8c4d76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.