Commit 4f5598b
authored
Linked Time: Enable range selection when linked time is enabled while linked time selection has an end value (#6264)
## Motivation for features / changes
Linked time is supposed to make all cards mirror the state of the card
most recently interacted with. Because cards can have range selection
enabled locally we need to ensure the global value gets updated when
linked time is enabled.
## Technical description of changes
I updated the linked time toggled reducer to enable range selection
globally if the linked time selection has an end value.
For Googlers: [internal tests all
pass](https://fusion2.corp.google.com/presubmit/tap/518701168/OCL:518701168:BASE:518705279:1679528159833:1e20cf2f/targets)
## Screenshots of UI changes

## Detailed steps to verify changes work correctly (as executed by you)
See gif
1) Start tensorboard
2) Navigate to localhost:6006
3) Ensure global step selection is disabled
4) Add two fobs to a scalar card
5) Enable linked time
6) Ensure range selection is enabled globally1 parent 73f1609 commit 4f5598b
File tree
2 files changed
+48
-0
lines changed- tensorboard/webapp/metrics/store
2 files changed
+48
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1046 | 1046 | | |
1047 | 1047 | | |
1048 | 1048 | | |
| 1049 | + | |
1049 | 1050 | | |
1050 | 1051 | | |
1051 | 1052 | | |
| |||
1055 | 1056 | | |
1056 | 1057 | | |
1057 | 1058 | | |
| 1059 | + | |
1058 | 1060 | | |
1059 | 1061 | | |
1060 | 1062 | | |
| |||
1063 | 1065 | | |
1064 | 1066 | | |
1065 | 1067 | | |
| 1068 | + | |
1066 | 1069 | | |
1067 | 1070 | | |
1068 | 1071 | | |
| |||
1071 | 1074 | | |
1072 | 1075 | | |
1073 | 1076 | | |
| 1077 | + | |
1074 | 1078 | | |
1075 | 1079 | | |
1076 | 1080 | | |
| |||
Lines changed: 44 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3551 | 3551 | | |
3552 | 3552 | | |
3553 | 3553 | | |
| 3554 | + | |
| 3555 | + | |
| 3556 | + | |
| 3557 | + | |
| 3558 | + | |
| 3559 | + | |
| 3560 | + | |
| 3561 | + | |
| 3562 | + | |
| 3563 | + | |
| 3564 | + | |
| 3565 | + | |
3554 | 3566 | | |
3555 | 3567 | | |
3556 | 3568 | | |
| |||
3690 | 3702 | | |
3691 | 3703 | | |
3692 | 3704 | | |
| 3705 | + | |
| 3706 | + | |
| 3707 | + | |
| 3708 | + | |
| 3709 | + | |
| 3710 | + | |
| 3711 | + | |
| 3712 | + | |
| 3713 | + | |
| 3714 | + | |
| 3715 | + | |
| 3716 | + | |
| 3717 | + | |
| 3718 | + | |
| 3719 | + | |
| 3720 | + | |
| 3721 | + | |
| 3722 | + | |
| 3723 | + | |
| 3724 | + | |
| 3725 | + | |
| 3726 | + | |
| 3727 | + | |
| 3728 | + | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
| 3732 | + | |
| 3733 | + | |
| 3734 | + | |
| 3735 | + | |
| 3736 | + | |
3693 | 3737 | | |
3694 | 3738 | | |
3695 | 3739 | | |
| |||
0 commit comments