Skip to content

Conversation

@vkuma17
Copy link
Contributor

@vkuma17 vkuma17 commented Oct 7, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vkuma17 vkuma17 marked this pull request as draft October 7, 2025 09:12
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 9, 2025

I will address review comments @ocofaigh. I just pushed changes so that i can run the addon test locally. This PR is still work in progress. Thankyou.

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 20, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkuma17 Lets forget about v2 versions, and go straight to v3 versions. I'm going to push a new commit to the PR with some changes..

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 20, 2025

@vkuma17 Lets forget about v2 versions, and go straight to v3 versions. I'm going to push a new commit to the PR with some changes..

Sure @ocofaigh

@ocofaigh ocofaigh marked this pull request as ready for review October 20, 2025 15:14
@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh
Copy link
Contributor

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 21, 2025

/run pipeline

2 similar comments
@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 21, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 21, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 21, 2025

/run pipeline

@vkuma17 vkuma17 requested a review from ocofaigh October 21, 2025 14:16
@ocofaigh ocofaigh merged commit e6f58b6 into main Oct 21, 2025
2 checks passed
@ocofaigh ocofaigh deleted the addons branch October 21, 2025 15:11
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants