fix: remove null optional elements before jsonencode is called (resolves this [bug](#273) (#284)

Author: akocbek

examples/complete/README.md

@@ -5,6 +5,7 @@ An end-to-end example that does the following:
 - Create a new resource group if one is not passed in.
 - Create Key Protect instance with root key.
 - Create a new ICD PostgreSQL database instance with BYOK encryption.
+- Set 250 max connection for ICD PostgreSQL database instance.
 - Create service credentials for the database instance.
 - Create a Virtual Private Cloud (VPC).
 - Create Context Based Restriction (CBR) to only allow Postgresql to be accessible from the VPC.

examples/complete/main.tf

@@ -83,6 +83,9 @@ module "postgresql_db" {
   resource_tags              = var.resource_tags
   service_credential_names   = var.service_credential_names
   access_tags                = var.access_tags
+  configuration = {
+    max_connections = 250
+  }
   cbr_rules = [
     {
       description      = "${var.prefix}-postgres access only from vpc"

main.tf

@@ -48,20 +48,21 @@ resource "time_sleep" "wait_for_authorization_policy" {
 
 # Create postgresql database
 resource "ibm_database" "postgresql_db" {
-  depends_on                           = [ibm_iam_authorization_policy.kms_policy]
-  resource_group_id                    = var.resource_group_id
-  name                                 = var.name
-  service                              = "databases-for-postgresql"
-  location                             = var.region
-  plan                                 = "standard" # Only standard plan is available for postgres
-  backup_id                            = var.backup_crn
-  plan_validation                      = var.plan_validation
-  remote_leader_id                     = var.remote_leader_crn
-  version                              = var.pg_version
-  tags                                 = var.resource_tags
-  adminpassword                        = var.admin_pass
-  service_endpoints                    = var.service_endpoints
-  configuration                        = var.configuration != null ? jsonencode(var.configuration) : null
+  depends_on        = [ibm_iam_authorization_policy.kms_policy]
+  resource_group_id = var.resource_group_id
+  name              = var.name
+  service           = "databases-for-postgresql"
+  location          = var.region
+  plan              = "standard" # Only standard plan is available for postgres
+  backup_id         = var.backup_crn
+  plan_validation   = var.plan_validation
+  remote_leader_id  = var.remote_leader_crn
+  version           = var.pg_version
+  tags              = var.resource_tags
+  adminpassword     = var.admin_pass
+  service_endpoints = var.service_endpoints
+  # remove elements with null values: see https://github.com/terraform-ibm-modules/terraform-ibm-icd-postgresql/issues/273
+  configuration                        = var.configuration != null ? jsonencode({ for k, v in var.configuration : k => v if v != null }) : null
   key_protect_key                      = var.kms_key_crn
   backup_encryption_key_crn            = local.backup_encryption_key_crn
   point_in_time_recovery_deployment_id = var.pitr_id

module-metadata.json

@@ -523,7 +523,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 190
+        "line": 191
       }
     },
     "ibm_resource_tag.postgresql_tag": {
@@ -539,7 +539,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 141
+        "line": 142
       }
     },
     "time_sleep.wait_for_authorization_policy": {
@@ -571,7 +571,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 218
+        "line": 219
       }
     }
   },
@@ -650,7 +650,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 151
+        "line": 152
       }
     }
   }