Merge pull request #835 from testing-library/feature/fix-find-by-label-text-suggestion

fix(suggestions): don't suggest byLabelText when using byLabelText

Author: benmonro

src/__tests__/suggestions.js

@@ -232,6 +232,16 @@ test('should suggest getByLabelText when no role available', () => {
   )
 })
 
+it('should not suggest by label when using by label', async () => {
+  renderIntoDocument(
+    `<label><span>bar</span><input type="password" title="foo" /></label>`,
+  )
+
+  // if a suggestion is made, this call will throw, thus failing the test.
+  const password = await screen.findByLabelText(/bar/i)
+  expect(password).toHaveAttribute('type', 'password')
+})
+
 test(`should suggest getByLabel on non form elements`, () => {
   renderIntoDocument(`
   <div data-testid="foo" aria-labelledby="section-one-header">

src/queries/label-text.js

@@ -169,7 +169,7 @@ const findAllByLabelText = makeFindQuery(
   ),
 )
 const findByLabelText = makeFindQuery(
-  wrapSingleQueryWithSuggestion(getByLabelText, getByLabelText.name, 'find'),
+  wrapSingleQueryWithSuggestion(getByLabelText, getAllByLabelText.name, 'find'),
 )
 
 const getAllByLabelTextWithSuggestions = wrapAllByQueryWithSuggestion(