Question: allowLists: true but match list item

[Mister-Hope]

Heres the docs

And here is my config:

rules:
  "@textlint-rule/no-unmatched-pair": true

  apostrophe: true

  common-misspellings: true

  diacritics: true

  en-capitalization:
    allowHeading: false
    allowLists: true

  # stop-words:
  #   severity: warning

  # terminology:
  #   terms:
  #     - Stylus
  #     - VuePress
  #     - - front[- ]matter
  #       - frontmatter
  #   exclude:
  #     - node
  #     - repo

  # write-good:
  #   severity: warning

  zh-half-and-full-width-bracket:
    bracket: halfWidth

filters:
  comments: true

Then why is the plugin still correcting this:

[azu]

Fmm. allowLists aim to ignore list item text.

Its may be a bug.

textlint-rule-en-capitalization/src/textlint-rule-en-capitalization.js

Line 149 in d4c21fa

[Syntax.ListItem](node) {

[Mister-Hope]

It seems that the logic is reversed

  en-capitalization:
    allowHeading: false
    allowLists: false

This will allow lowercase letter in heading and lists.

Besides, why there is allowLists, allowFigures, allowWords while allowHeading? It's strange.

[Mister-Hope]

I would like to open a pr, fixing the logic while changing allowHeading to allowHeadings, as reversing the logic back is absolutely a breaking change. Or I can remove all the allow prefix and let users to set false to ignore.

Then we should publish a major version. What's your opinion? @azu

[Mister-Hope]

Any update about this one?

[azu]

Sorry to late.

I would like to open a pr, fixing the logic while changing allowHeading to allowHeadings, as reversing the logic back is absolutely a breaking change. Or I can remove all the allow prefix and let users to set false to ignore.

Yes, we need to fix the bug and change options.
I agree with breaking change.
It is good that change each option name. Additionaly, check the deprecated options name and show error message.

e.g.

Please use headings(more good name) instead of allowHeading