Change return value of getRedirectType to empty array instead of null

Author: Mike Feijs

src/Message/ExpressAuthorizeResponse.php

@@ -39,7 +39,7 @@ public function getRedirectMethod()
 
     public function getRedirectData()
     {
-        return null;
+        return [];
     }
 
     protected function getRedirectQueryParameters()

src/Message/RestAuthorizeResponse.php

@@ -91,10 +91,10 @@ public function getRedirectMethod()
     /**
      * Gets the redirect form data array, if the redirect method is POST.
      *
-     * @return null
+     * @return array
      */
     public function getRedirectData()
     {
-        return null;
+        return [];
     }
 }

tests/Message/ExpressAuthorizeResponseTest.php

@@ -26,7 +26,7 @@ public function testExpressPurchaseSuccess()
         $this->assertFalse($response->isSuccessful());
         $this->assertSame('EC-42721413K79637829', $response->getTransactionReference());
         $this->assertNull($response->getMessage());
-        $this->assertNull($response->getRedirectData());
+        $this->assertEquals([], $response->getRedirectData());
         $this->assertSame('https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_express-checkout&useraction=commit&token=EC-42721413K79637829', $response->getRedirectUrl());
         $this->assertSame('GET', $response->getRedirectMethod());
     }

tests/Message/ExpressInContextAuthorizeResponseTest.php

@@ -26,7 +26,7 @@ public function testExpressPurchaseSuccess()
         $this->assertFalse($response->isSuccessful());
         $this->assertSame('EC-42721413K79637829', $response->getTransactionReference());
         $this->assertNull($response->getMessage());
-        $this->assertNull($response->getRedirectData());
+        $this->assertEquals([], $response->getRedirectData());
         $this->assertSame('https://www.sandbox.paypal.com/checkoutnow?useraction=commit&token=EC-42721413K79637829', $response->getRedirectUrl());
         $this->assertSame('GET', $response->getRedirectMethod());
     }
@@ -42,4 +42,4 @@ public function testExpressPurchaseFailure()
         $this->assertNull($response->getTransactionReference());
         $this->assertSame('This transaction cannot be processed. The amount to be charged is zero.', $response->getMessage());
     }
-}
+}

tests/Message/RestAuthorizeResponseTest.php

@@ -17,8 +17,8 @@ public function testRestPurchaseWithoutCardSuccess()
         $this->assertSame('PAY-3TJ47806DA028052TKTQGVYI', $response->getTransactionReference());
         $this->assertNull($response->getMessage());
 
-        $this->assertNull($response->getRedirectData());
+        $this->assertEquals([], $response->getRedirectData());
         $this->assertSame('GET', $response->getRedirectMethod());
         $this->assertSame('https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token=EC-5KV58254GL528393N', $response->getRedirectUrl());
     }
-}
+}