Skip to content

Commit fa841ef

Browse files
jxstelterlgirdwood
authored andcommitted
iadk: Fix GetConfiguration API function
The GetConfiguration function was incorrectly defined for IADK module adapter. This patch fixes the definition. Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com> Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
1 parent 93c7889 commit fa841ef

File tree

3 files changed

+24
-12
lines changed

3 files changed

+24
-12
lines changed

src/audio/module_adapter/iadk/iadk_module_adapter.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ IadkModuleAdapter::IadkModuleAdapter_SetConfiguration(uint32_t config_id,
121121
AdspErrorCode
122122
IadkModuleAdapter::IadkModuleAdapter_GetConfiguration(uint32_t config_id,
123123
enum module_cfg_fragment_position pos,
124-
uint32_t data_offset_size,
124+
uint32_t &data_offset_size,
125125
uint8_t *fragment_buffer,
126-
size_t fragment_size)
126+
size_t &fragment_size)
127127
{
128128
intel_adsp::ConfigurationFragmentPosition fragment_position =
129129
(intel_adsp::ConfigurationFragmentPosition::Enum) pos;
@@ -219,14 +219,14 @@ int iadk_wrapper_set_configuration(void *md, uint32_t config_id,
219219

220220
int iadk_wrapper_get_configuration(void *md, uint32_t config_id,
221221
enum module_cfg_fragment_position pos,
222-
uint32_t data_offset_size,
223-
uint8_t *fragment, size_t fragment_size)
222+
uint32_t *data_offset_size,
223+
uint8_t *fragment, size_t *fragment_size)
224224
{
225225
struct IadkModuleAdapter *mod_adp = (struct IadkModuleAdapter *) md;
226226
return mod_adp->IadkModuleAdapter_GetConfiguration(config_id, pos,
227-
data_offset_size,
227+
*data_offset_size,
228228
fragment,
229-
fragment_size);
229+
*fragment_size);
230230
}
231231

232232
int iadk_wrapper_process(void *md,

src/audio/module_adapter/module/modules.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,8 @@ static int modules_get_configuration(struct processing_module *mod, uint32_t con
191191
size_t fragment_size)
192192
{
193193
return iadk_wrapper_get_configuration(module_get_private_data(mod), config_id,
194-
MODULE_CFG_FRAGMENT_SINGLE, *data_offset_size,
195-
fragment, fragment_size);
194+
MODULE_CFG_FRAGMENT_SINGLE, data_offset_size,
195+
fragment, &fragment_size);
196196
}
197197

198198
/**

src/include/sof/audio/module_adapter/iadk/iadk_module_adapter.h

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ namespace dsp_fw
9191
AdspErrorCode
9292
IadkModuleAdapter_GetConfiguration(uint32_t config_id,
9393
enum module_cfg_fragment_position fragment_position,
94-
uint32_t data_offset_size,
94+
uint32_t &data_offset_size,
9595
uint8_t *fragment_buffer,
96-
size_t fragment_size);
96+
size_t &fragment_size);
9797
/**
9898
* Module specific reset procedure, called as part of codec_adapter component
9999
* reset in .reset(). This should reset all parameters to their initial stage
@@ -144,10 +144,22 @@ int iadk_wrapper_set_configuration(void *md, uint32_t config_id,
144144
const uint8_t *fragment, size_t fragment_size,
145145
uint8_t *response, size_t response_size);
146146

147+
/*
148+
* \brief Retrieve module configuration
149+
* \param[in] md - struct IadkModuleAdapter pointer
150+
* \param[in] config_id - Configuration ID
151+
* \param[in] pos - position of the fragment in the large message
152+
* \param[in] data_offset_size: size of the whole configuration if it is the first fragment or the
153+
* only fragment. Otherwise, it is the offset of the fragment in the whole configuration.
154+
* \param[in] fragment: configuration fragment buffer
155+
* \param[in,out] fragment_size: size of @fragment
156+
*
157+
* \return: 0 upon success or error upon failure
158+
*/
147159
int iadk_wrapper_get_configuration(void *md, uint32_t config_id,
148160
enum module_cfg_fragment_position pos,
149-
uint32_t data_offset_size,
150-
uint8_t *fragment, size_t fragment_size);
161+
uint32_t *data_offset_size,
162+
uint8_t *fragment, size_t *fragment_size);
151163

152164
int iadk_wrapper_process(void *md,
153165
struct sof_source **sources, int num_of_sources,

0 commit comments

Comments
 (0)