From 6ca8ff11943a19a797e94230018c560145c3d056 Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski Date: Fri, 22 Aug 2025 10:07:49 +0200 Subject: [PATCH 1/2] module-adapter: move a calculation outside a loop The size calculation in module_adapter_prepare() is constant over all loop iterations, move it out of the loop. Signed-off-by: Guennadi Liakhovetski --- src/audio/module_adapter/module_adapter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/audio/module_adapter/module_adapter.c b/src/audio/module_adapter/module_adapter.c index 0e5aa1f42082..defba3a3785c 100644 --- a/src/audio/module_adapter/module_adapter.c +++ b/src/audio/module_adapter/module_adapter.c @@ -422,9 +422,9 @@ int module_adapter_prepare(struct comp_dev *dev) mod->output_buffer_size = buff_size; /* allocate memory for input buffer data */ - list_for_item(blist, &dev->bsource_list) { - size_t size = MAX(mod->deep_buff_bytes, mod->period_bytes); + size_t size = MAX(mod->deep_buff_bytes, mod->period_bytes); + list_for_item(blist, &dev->bsource_list) { mod->input_buffers[i].data = rballoc(memory_flags, size); if (!mod->input_buffers[i].data) { comp_err(mod->dev, "Failed to alloc input buffer data"); From aba91e54bf4f83ade55806832ce8341e95a56ea3 Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski Date: Fri, 22 Aug 2025 10:12:53 +0200 Subject: [PATCH 2/2] ipc: (cosmetic) remove a redundant statement Remove a redundant return statement. Signed-off-by: Guennadi Liakhovetski --- src/ipc/ipc-helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ipc/ipc-helper.c b/src/ipc/ipc-helper.c index 896fedf15463..0b34915ea26f 100644 --- a/src/ipc/ipc-helper.c +++ b/src/ipc/ipc-helper.c @@ -175,7 +175,6 @@ int comp_verify_params(struct comp_dev *dev, uint32_t flag, * there's just nothing to update */ comp_dbg(dev, "no connected buffers"); - return 0; } else { /* for other components we iterate over all downstream buffers * (for playback) or upstream buffers (for capture).