From b495232fdae29ec4e2e083ba6603262ea6c41d75 Mon Sep 17 00:00:00 2001 From: Jyri Sarha Date: Thu, 4 Sep 2025 22:09:32 +0300 Subject: [PATCH] cmocka: eq_iir and eq_fir: Fix test crash Assign mod->stream_params to NULL aftere it is freed. If this is not done comp_free() tries to free it again couple of lines later, when it calls module_adapter_free(). Removing test_free(mod->stream_params) does not fix the issue because cmocka framework provided test_alloc() and test_free() are not equivalent to malloc() and free(). Signed-off-by: Jyri Sarha --- test/cmocka/src/audio/eq_fir/eq_fir_process.c | 1 + test/cmocka/src/audio/eq_iir/eq_iir_process.c | 1 + 2 files changed, 2 insertions(+) diff --git a/test/cmocka/src/audio/eq_fir/eq_fir_process.c b/test/cmocka/src/audio/eq_fir/eq_fir_process.c index 2b657c23c2fb..a7087fa7c470 100644 --- a/test/cmocka/src/audio/eq_fir/eq_fir_process.c +++ b/test/cmocka/src/audio/eq_fir/eq_fir_process.c @@ -186,6 +186,7 @@ static int teardown(void **state) test_free(mod->input_buffers); test_free(mod->output_buffers); test_free(mod->stream_params); + mod->stream_params = NULL; test_free(td->params); free_test_source(td->source); free_test_sink(td->sink); diff --git a/test/cmocka/src/audio/eq_iir/eq_iir_process.c b/test/cmocka/src/audio/eq_iir/eq_iir_process.c index 763d87b87518..9df4d17af864 100644 --- a/test/cmocka/src/audio/eq_iir/eq_iir_process.c +++ b/test/cmocka/src/audio/eq_iir/eq_iir_process.c @@ -185,6 +185,7 @@ static int teardown(void **state) test_free(mod->input_buffers); test_free(mod->output_buffers); test_free(mod->stream_params); + mod->stream_params = NULL; test_free(td->params); free_test_source(td->source); free_test_sink(td->sink);