From a77008df7f201d0d0208b39123aaf10f2811d481 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Tue, 9 Dec 2025 15:45:21 -0800 Subject: [PATCH] .github: really disable spar-se instead of breaking it Fixes commit 56649f6c158b ("github: workflows: disable sparse checks temporarily") which caused a syntax error GitHub jobs can be disabled one by one but not all at once: https://docs.github.com/en/actions/reference/workflows-and-actions/ workflow-syntax#jobsjob_idif This syntax error was found by Copilot; quoting: https://github.com/thesofproject/sof/pull/10337#discussion_r2470608489 > The if: false statement is incorrectly placed at the file level > between jobs: and the job definition. This will cause a syntax > error. It should be placed within a specific job definition. Move this > line and the preceding comments to be indented under the job > name (e.g., after the job key on the next line This has blocked daily tests from running for ages: https://github.com/thesofproject/sof/actions/runs/20048113632 ``` Invalid workflow file: .github/workflows/daily-tests.yml#L42 error parsing called workflow ".github/workflows/daily-tests.yml" -> "./.github/workflows/sparse-zephyr.yml" (source branch with sha:e00764e7fbe3315c0d8e1fa87624aec4e37db7e3) : (Line: 17, Col: 7): Unexpected value 'false' ``` Signed-off-by: Marc Herbert --- .github/workflows/sparse-zephyr.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/sparse-zephyr.yml b/.github/workflows/sparse-zephyr.yml index 3979d38175c3..e66856691dcb 100644 --- a/.github/workflows/sparse-zephyr.yml +++ b/.github/workflows/sparse-zephyr.yml @@ -12,16 +12,15 @@ defaults: shell: bash jobs: - # disable until https://github.com/zephyrproject-rtos/zephyr/issues/93444 - # is fixed - if: false - # As of sparse commit ce1a6720f69e / Sept 2022, the exit status of # sparse.c is an unusable mess and always zero in practice. Moreover # SOF has hundreds of sparse warnings right now. So fail only on a # small subset of specific warnings defined in # sof/scripts/parse_sparse_output.sh warnings-subset: + # disable until https://github.com/zephyrproject-rtos/zephyr/issues/93444 + # is fixed + if: false # We're sharing the sparse binary with the zephyr-build container so keep # this in sync with it.